Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use AccumulatorMeanStack for coadds #5

Open
esheldon opened this issue Mar 19, 2024 · 1 comment
Open

use AccumulatorMeanStack for coadds #5

esheldon opened this issue Mar 19, 2024 · 1 comment

Comments

@esheldon
Copy link
Collaborator

We can't do it now, but from Arun:

Reading in the images is required to bring them to the same zero point before coadding (lines 420-421). There's work happening just this week and in the coming weeks to make all those calibrations on the calexp after which those lines would not be required. We can switch to passing the refs to make_coadd then, but let's leave this in as is for this PR.
@arunkannawadi
Copy link
Member

arunkannawadi commented Mar 19, 2024

I don't think this is an issue, or at least, the title is very misleading. The task still uses AccumulatorMeanStack for coaddition. It is just that all of the images are currently being read before passing them to AccumulatorMeanStack (but only as subimages). I'd mark this as duplicate of #6 and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants