Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for unknown stage parameters #95

Open
jlvdb opened this issue Aug 2, 2023 · 0 comments
Open

Check for unknown stage parameters #95

jlvdb opened this issue Aug 2, 2023 · 0 comments

Comments

@jlvdb
Copy link
Contributor

jlvdb commented Aug 2, 2023

PipelineStage.make_stage() has no fixed signature. If the method is called with an unknown stage parameter (e.g. by mistyping the name), it does not throw an exception but instead silently discards the value because it cannot be mapped to any of the defined stage parameters.

Suggestion:
Add a check in StageConfig.set_config() for any keys that are not present in its underlying stage parameter dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant