Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: simplify get_covariance_block methods and keep only the _for_sacc one #69

Open
carlosggarcia opened this issue Jan 5, 2023 · 1 comment
Open

API: simplify get_covariance_block methods and keep only the _for_sacc one #69

carlosggarcia opened this issue Jan 5, 2023 · 1 comment

Comments

@carlosggarcia
Copy link
Contributor

At the moment, there are two public methods get_covariance_block and get_covariance_block_for_sacc. The former returns the covariance block as given by an external code (e.g. NaMaster), whereas the latter returns it like expected for the sacc file. I think this is going to be confusing and we should only keep as public method get_covariance_block_for_sacc.
@felipeaoli
Copy link
Collaborator

I am not sure what is the best decision here but now the get_covariance_block_for_sacc is implemented only in Fourier case. Any thoughts? Should I close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlosggarcia @felipeaoli