Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear sum assignment matching failure #345

Open
mpaillassa opened this issue Aug 5, 2022 · 1 comment
Open

Linear sum assignment matching failure #345

mpaillassa opened this issue Aug 5, 2022 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@mpaillassa
Copy link
Collaborator

This is a failure that should be very rare so it's not necessary to fix this right now but it can happen that the linear sum assignment matching fails to return the appropriate match between predicted and ground truth sources.

Let's consider the case below:
matching_fail drawio

If a false detection like pred2 is far enough, it can happen that:
$dist(pred1, gal2) + dist(pred2, gal1) < dist(pred1, gal1) + dist(pred2, gal2)$,
in which case the solution is to assign pred1 to gal2 and pred2 to gal1. Then, applying the distance criterion, we will likely end up with no predictions matching any ground truth, which is not what we would expect.

A simple solution is to check the matches: if there are no matches at all, we may be in that case and we can just to loop through predicted and ground truth objects to manually match them when the distance criterion is respected, in which case we will end up matching pred1 to gal1 and leaving pred2 as a false detection and gal2 as a false negative.

@ismael-mendoza ismael-mendoza added the bug Something isn't working label Aug 25, 2022
@ismael-mendoza
Copy link
Collaborator

ismael-mendoza commented Sep 9, 2022

Consider DC2 matching -> check magnitude of objects (something like a safety check)

Or use a different distance metric

@ismael-mendoza ismael-mendoza added this to the 1.1.0 milestone Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants