Display artist#1576
Open
darrell-k wants to merge 26 commits into
Open
Conversation
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Signed-off-by: Rouzax <GitHub@mgdn.nl>
Signed-off-by: Rouzax <GitHub@mgdn.nl>
In updateOrCreateBase, capture albumDisplayArtist and trackDisplayArtist from the attributeHash before _preCheckAttributes strips/defers them. Pass both values to _postCheckAttributes, which now calls _getOrCreateDisplayContributor for each, writes display_contributor to the track row, and forwards both IDs to _createOrUpdateAlbum and _createContributorRoleRelationships. Without this, rescanning an existing track never updated display_contributor. Signed-off-by: Martijn Frazer <claude@mgdn.nl> Signed-off-by: Rouzax <GitHub@mgdn.nl>
Signed-off-by: Rouzax <GitHub@mgdn.nl>
Signed-off-by: Rouzax <GitHub@mgdn.nl>
Signed-off-by: Rouzax <GitHub@mgdn.nl>
Signed-off-by: Rouzax <GitHub@mgdn.nl>
Signed-off-by: Rouzax <GitHub@mgdn.nl>
Register usePluralArtistTags in Behavior.pm prefs list so the web UI can save it. Add to the setChange wipecache list so toggling the pref triggers a rescan. Handle scalar plural tags (e.g. semicolon-joined ALBUMARTISTS from TXXX) by routing through splitTag instead of requiring an arrayref. Signed-off-by: Rouzax <GitHub@mgdn.nl>
Signed-off-by: Rouzax <GitHub@mgdn.nl>
Functional changes for display_artist on 3NF schema
Closed
9 tasks
Contributor
|
Also wanted to leave my draft documentation here as well |
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Display Artist: Simplify Scan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective:
To capture the "human readable" artist tag from eg Musicbrainz as well as the underlying list of individual artists and provide this data to clients.
eg
ARTIST="Bill Evans Trio with Scott LaFaro and Paul Motian"
ARTISTS="Bill Evans; Scott LaFaro; Paul Motian"
Design:
New table
contributor_displayto hold these display names. Rows will not be created in the existingcontributortable.New join tables
contributor_track_displayandcontributor_album_displayto relatecontributor_display.idto the tracks/albums and the actual contributors below the display name.New columns in the
albumsandtrackstables to hold contributor_display.id.Amend queries to return the new data.
Add the display artist to FTS album and track rows.
The scanning changes will be optional, with a new preference, in case users have already fixed their tags and do not want this functionality.
With thanks to @Rouzax