Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR was made for this branch mainly for developers and users to see the effects removing the FIFO thread will have, either good or bad. The choice for merge, as with all PRs, is at the discretion of those who tested it and the overall community. I am not necessarily pushing a merge here. As I will discuss, there are a few gray areas involving this whole situation, and I think being able to see the changes yourself can clear things up a bit for everyone.
This PR removes
AudioEngine::fifoWriter
, which is a thread that facilities the multiple buffering mechanism we have currently for our audio rendering. The way the mechanism works (to my understanding):original_buffer_size / 256
and waits for someone to request a chunk.Pros to having this thread:
This was the only main benefit I could think of as of right now: this thread acts as a bandage for maintaining somewhat accurate automation regardless of buffer sizes. Let me know if I missed something.
Cons to having this thread:
Other notes:
output.mp4