Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Beat Preview to PatternClipView #7559

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

regulus79
Copy link
Contributor

@regulus79 regulus79 commented Oct 23, 2024

This PR changes the way PatternClips are drawn in include a simple "beat preivew," where each note in any non-empty instrument tracks within the pattern are drawn as 1/16 long rectangles on the ClipView. SampleClips and AutomationClips within patterns are not currently supported.

Note

I am not currently satisfied with the state of the visualization; perhaps some of you may have ideas on how to make it better, and/or if it should be optional (perhaps the solid color clips could be appealing to some)

Demo

pattern_clip_view_beat_preview_demo.mp4

(why is github thinking this is an audio file?)

image

Todo

  • Fix clip view not updating when note velocity changes
  • Add SampleClip support (likely going to be adding a single note rectangle at the sample startoffset)
  • Add AutomationClip support (or not)
  • Fix graphical bug of horizontal line of empty pixels
  • Fix the drawing of notes to be between the clip highlight, otherwise the notes near the top and bottom botder will be slightly hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant