Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sample thumbnails #7366

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

Add sample thumbnails #7366

wants to merge 47 commits into from

Commits on Jul 2, 2024

  1. Experimental sample thumbnail

    @khoidauminh
    khoidauminh committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5ad7845 View commit details
    Browse the repository at this point in the history

  2. Rename some classes and type aliases. Make some type declarations exp… 

    …licit
    @khoidauminh
    khoidauminh committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    795ad7f View commit details
    Browse the repository at this point in the history

  3. Use a combination of audioFile name and shared_ptrs to track samples;… 

    … refactor some loops
    @khoidauminh
    khoidauminh committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    140006b View commit details
    Browse the repository at this point in the history

  4. That weird line at the end of the sample is now gone

    @khoidauminh
    khoidauminh committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    14d1e91 View commit details
    Browse the repository at this point in the history

  5. Small changes to the code; Add comments

    @khoidauminh
    khoidauminh committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    71284b0 View commit details
    Browse the repository at this point in the history

  6. Add missing word to comment; Fix typo

    @khoidauminh
    khoidauminh committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    4553283 View commit details
    Browse the repository at this point in the history

  7. Track SharedSampleThumbnailLists instead

    @khoidauminh
    khoidauminh committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7a6e2aa View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Major refactor; implement thumbnailing for SlicerT, AFP and Automatio… 

    …n editor
    @khoidauminh
    khoidauminh committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f281961 View commit details
    Browse the repository at this point in the history

  2. Code clean up, renames and documenting

    @khoidauminh
    khoidauminh committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e03dacd View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Merge branch 'LMMS:master' into sample-thumbnail

    @khoidauminh
    khoidauminh authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    4a1689e View commit details
    Browse the repository at this point in the history

  2. Add the namespace lmms comments

    @khoidauminh
    khoidauminh committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    82c51e0 View commit details
    Browse the repository at this point in the history

  3. More code updates and documentation

    @khoidauminh
    khoidauminh committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    35589f9 View commit details
    Browse the repository at this point in the history

  4. Fix error in comment

    @khoidauminh
    khoidauminh committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    92b9c15 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Comment out qDebugs

    @khoidauminh
    khoidauminh committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    fa24cfe View commit details
    Browse the repository at this point in the history

  2. Fix formatting

    @khoidauminh
    khoidauminh committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    101199e View commit details
    Browse the repository at this point in the history

  3. Use alternative initialization of SampleThumbnailVisualizeParameters

    @khoidauminh
    khoidauminh committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b903d9f View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Remove commented code

    @khoidauminh
    khoidauminh committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7a393ef View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Fix style and simplify code

    @sakertooth
    sakertooth committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    4e39c16 View commit details
    Browse the repository at this point in the history

  2. Use auto

    @sakertooth
    sakertooth committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9880d83 View commit details
    Browse the repository at this point in the history

  3. Draw lines using floating point

    @sakertooth
    sakertooth committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    69cc6ba View commit details
    Browse the repository at this point in the history

  4. Merge the classes into one nested class 

    + Replace while loop with std::find_if
    @sakertooth
    sakertooth committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d7f89ac View commit details
    Browse the repository at this point in the history

  5. Fix comparison of different signedness

    @sakertooth
    sakertooth committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9605dec View commit details
    Browse the repository at this point in the history

  6. Include memory header

    @sakertooth
    sakertooth committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7f3d43f View commit details
    Browse the repository at this point in the history

  7. Fix a logic error when selecting samples; Rename a const

    @khoidauminh
    khoidauminh committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3c41384 View commit details
    Browse the repository at this point in the history

  8. Fix more issues with signedness

    @sakertooth
    sakertooth committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5f70d59 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Fix sample drawing error in visualizeOriginal

    @khoidauminh
    khoidauminh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    4f9f353 View commit details
    Browse the repository at this point in the history

  2. Only render regions in view of the sample

    @khoidauminh
    khoidauminh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    12bc9cc View commit details
    Browse the repository at this point in the history

  3. Allow partial repaints of sample clips

    @khoidauminh
    khoidauminh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0a210ee View commit details
    Browse the repository at this point in the history

  4. Remove unused variable

    @khoidauminh
    khoidauminh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d6a3638 View commit details
    Browse the repository at this point in the history

  5. Limit most of the painting to the visible region

    @khoidauminh
    khoidauminh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    305baee View commit details
    Browse the repository at this point in the history

  6. Revert back to using rect() in some places

    @khoidauminh
    khoidauminh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9392493 View commit details
    Browse the repository at this point in the history

  7. Partial rendering for AutomationEditor

    @khoidauminh
    khoidauminh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    4bc9dae View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Don't redraw painted regions; allowHighResolution; remove `visualizeO… 

    …riginal`; Remove s_sampleThumbnailCacheMap
    @khoidauminh
    khoidauminh committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5cd947b View commit details
    Browse the repository at this point in the history

  2. Add s_sampleThumbnailCacheMap back for testing convenience

    @khoidauminh
    khoidauminh committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    daf45cc View commit details
    Browse the repository at this point in the history

  3. Minor change to the way thumbnailSizeDivisor is calculated

    @khoidauminh
    khoidauminh committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2c2202f View commit details
    Browse the repository at this point in the history

  4. Extend update region by an amount

    @khoidauminh
    khoidauminh committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0317e80 View commit details
    Browse the repository at this point in the history

  5. forgot about this

    @khoidauminh
    khoidauminh committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bfb5367 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'LMMS:master' into sample-thumbnail

    @khoidauminh
    khoidauminh authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    547e513 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Adapt to master; Redesign VisualizeParameters; Don't rely entirely on… 

    … needsUpdate()
    @khoidauminh
    khoidauminh committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    834e861 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge branch 'master' into sample-thumbnail

    @khoidauminh
    khoidauminh authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    cfa35e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge branch 'LMMS:master' into sample-thumbnail

    @khoidauminh
    khoidauminh authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0b8315c View commit details
    Browse the repository at this point in the history

  2. Don't try to preserve painted regions

    @khoidauminh
    khoidauminh committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    240696d View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Allow for a bit more thumbnails; Fix incorrect rendering when vertica… 

    …lly scrolling
    @khoidauminh
    khoidauminh committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b6cf4e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Merge branch 'master' into sample-thumbnail

    @khoidauminh
    khoidauminh authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ab3f0d1 View commit details
    Browse the repository at this point in the history

  2. Fix missing include statement

    @khoidauminh
    khoidauminh committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    58a98a4 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Merge branch 'master' into sample-thumbnail

    @khoidauminh
    khoidauminh authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b9bd512 View commit details
    Browse the repository at this point in the history

  2. Remove the unused variable

    @khoidauminh
    khoidauminh committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    38cd04d View commit details
    Browse the repository at this point in the history