Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VersionInfo: Not tagged refs should be resolved better #5250

Closed
Reflexe opened this issue Oct 18, 2019 · 2 comments
Closed

VersionInfo: Not tagged refs should be resolved better #5250

Reflexe opened this issue Oct 18, 2019 · 2 comments
Assignees
@Reflexe
Labels
cmake enhancement

Comments

@Reflexe
Copy link
Member

Reflexe commented Oct 18, 2019

Currently, for non-tagged commits, use parse version information from --match v[0-9].[0-9].[0-9]*.

That does no help a lot with non-tagged commit since it results something like v1.2.0-14. We should at least include the commit hash in the version info and the log and maybe also use dev for the rc field.
@Reflexe Reflexe self-assigned this Oct 18, 2019
@PhysSong
Copy link
Member

We should at least include the commit hash in the version info

It seems like we used to do it until #3011.

@PhysSong
Copy link
Member

PhysSong commented Oct 3, 2020

Done in #5636.

@PhysSong PhysSong closed this as completed Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reflexe Reflexe

Labels
cmake enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PhysSong @Reflexe