Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song-Editor. All patterns jump right side to one step, when track name changed. #5052

Closed
healingdrawing opened this issue Jun 21, 2019 · 12 comments

Comments

@healingdrawing
Copy link

Bug appear time to time. After restart LMMS, bug disappear, but later appear again.
All patterns of all tracks in Song-Editor move to one step right, when i rename track, or just , right mouse click on name and then press keyboard enter.
kubuntu 18.04
LMMS Version 1.2.0
test

@healingdrawing healingdrawing changed the title Sont-Editor. All patterns jump right side to one step, when track name changed. Song-Editor. All patterns jump right side to one step, when track name changed. Jun 21, 2019
@BaraMGB
Copy link
Contributor

BaraMGB commented Jun 21, 2019

looks very odd. It would be cool if we had a method to reproduce this. Perhaps you can provide your project file?

@healingdrawing
Copy link
Author

Perhaps you can provide your project file?

yes, it not secret. But no guarantee bug appear, when you change track name, because i had it only 5 times per three hours editing, with pauses.
_201906110544_xz_vball.mmpz.zip

@healingdrawing
Copy link
Author

and i detect additional point . When bug appears , and i try change name of track in time of playing global song in Song-Editor then only patterns which not covered by vertical play line + placed right from this position jumping right. Patterns which placed under play line and left, not moved. Then i stop playing change name again and in this case all patterns move right.

@BaraMGB
Copy link
Contributor

BaraMGB commented Jun 21, 2019

Thank you. I will try to reproduce this.

@BaraMGB
Copy link
Contributor

BaraMGB commented Jun 27, 2019

I can't reproduce it. Perhaps someone else is able to reproduce it and can provide steps that triggers this issue.

@DomClark
Copy link
Member

DomClark commented Jul 4, 2019

We have a shift+enter keyboard shortcut that does this, for easily inserting new bars. Presumably the shift modifier is stuck for some reason - I've seen reports of modifier keys getting stuck before, but I can't find any right now.

@healingdrawing
Copy link
Author

shift+enter keyboard shortcut that does this,

you are right shift+enter work.
Playing with shift+enter, I found next shitty point.
When i open empty project , which not lags when i press enter on keyboard etc(or change track name then enter), after i press once only shift+enter and tracks jump right, every next enter or num enter pressing , offset patterns inside song editor right to one step. Looks like shift freezed or stay like permanent artifact.
Little step forward, to founding dirty place.

@gthzrsfk
Copy link

I found the steps to reproduce.
Open piano-roll.
Move piano-roll if song-editor is entirely hidden.
Focus song-editor.
Pressing some modifier key, click on piano-roll.

@Spekular
Copy link
Member

Spekular commented May 28, 2020

The recent scroll direction fix also had to do with stuck modifiers, I wonder if that fixed this as well:

42f7e26

@GatoDev can you test a build of LMMS from master branch and see if the issue is still here? If you pick a minor PR on master branch and use the test binary from it you don't have to build it yourself.

This one should work, for example: #5510

Just click the show more arrow on LmmsBot's message.

@gthzrsfk
Copy link

I tested version 1.2.1.681 and confirmed it was fixed.

@Spekular
Copy link
Member

Great, thanks for testing! :)

@Spekular
Copy link
Member

Or, should this stay open since it's not fixed in 1.2? I think I lean towards having it closed since a fix is merged, but if someone disagrees please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants