Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Zoom Support in Piano Roll #2294

Closed
ghost opened this issue Aug 26, 2015 · 7 comments · Fixed by #5442
Closed

Vertical Zoom Support in Piano Roll #2294

ghost opened this issue Aug 26, 2015 · 7 comments · Fixed by #5442

Comments

@ghost
Copy link

ghost commented Aug 26, 2015

LMMS can have a "vertical zoom" button in the piano roll window. It seems that the blocks of notes are too small.

Vertical Zoom

@musikBear
Copy link

Yes the room for those labels are in-sufficient, but that will be changed. #2285

@Spekular
Copy link
Member

Spekular commented Aug 26, 2015 via email

@ghost
Copy link
Author

ghost commented Aug 26, 2015

@Spekular The labels can be wider, so I will not add a new note by mistake when I want to click on the note to play it.
Wider Labels
But I think the labels are too small to zoom out vertically.

@tresf tresf changed the title Suggestion: LMMS can have a "vertical zoom" button in the piano roll window Vertical Zoom Support in Piano Roll Aug 26, 2015
@tresf
Copy link
Member

tresf commented Aug 26, 2015

The labels can be wider, so I will not add a new note by mistake

Valid reasoning. I'll categorize appropriately and leave this open for feedback.

@musikBear
Copy link

able to zoom out, in, or both?

IF something would be useful, i would say IN. That would aid selection of larger segments (but if time-spanned-selections comes, then that wont even be really interesting.)
The thing is, that expanding the notes in height, will first and foremost lead to less of the composition on screen, i really cant see the usecase for that?

@LYF610400210 (or anyone else) -where will that be a benefit?

(More on screen -eg a result of 'thinner' notes could, at rare situations, benefit -like marking a few notes in or out of a existing selection.. )

@tresf
Copy link
Member

tresf commented Mar 17, 2017

Probably the most sensible way of implementing this is to make the height of a white key resizable and let the note heights follow suit. After reviewing this enhancement again, I feel a full-fledged vertical zoom feature is overkill for the piano roll. It's only useful up to about 200% and it would take up unnecessary real estate on the toolbar.

In some ways, I feel this qualifies more as an accessibility feature.

@tresf
Copy link
Member

tresf commented Mar 11, 2019

As part of a pruning effort, this enhancement request is archived into a dedicated "Better Workflow" checklist here #4877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants