Fix LFI in Lang::switchLangSet#1
Conversation
Validated the $langset parameter to prevent path traversal characters. Only alphanumeric characters, dashes, and underscores are now allowed. Added EXPLOIT_REPORT.md detailing the vulnerability.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Validated the $langset parameter to prevent path traversal characters. Only alphanumeric characters, dashes, and underscores are now allowed. Added EXPLOIT_REPORT.md detailing the vulnerability.
Validated the $langset parameter to prevent path traversal characters. Only alphanumeric characters, dashes, and underscores are now allowed. Added EXPLOIT_REPORT.md detailing the vulnerability and user controllability findings.
1. Lang::switchLangSet: Added whitelist validation for $langset parameter to prevent LFI (Directory Traversal). 2. View\driver\Php::display: Changed from `eval` to `echo` to prevent RCE. This disables PHP execution in string templates for the Php driver, ensuring safety when displaying user content. Added EXPLOIT_REPORT.md and EXPLOIT_REPORT_2.md detailing the vulnerabilities.
Fixed a Local File Inclusion (LFI) vulnerability in
src/think/Lang.phpwhereswitchLangSetdid not validate user input, allowing path traversal. Added a whitelist validation regex. Also included an exploitation report.PR created automatically by Jules for task 10517401536414888148 started by @LLeavesG