C++20 atomics #53
Open
C++20 atomics #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Hammond <jeff.r.hammond@intel.com>
New version uses functions not macros. The use of template functions allows for enforcement of type-safety, which is implemented using static_assert. The old implementation is preserved for posterity. A header guard was added. I found the old macro names confusing, so I used new names, but I map the old names in the source onto them so the application source does not change. Signed-off-by: Jeff Hammond <jeff.r.hammond@intel.com>
Signed-off-by: Jeff Hammond <jehammond@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves on #43 by adding a potentially universal implementation of atomics using C++20 atomic_ref.
Not everyone supports this right now but if compilers don't lie with feature test macros, the preprocessor will inform the user effectively.