Improve server typing #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
LKaemmerling
force-pushed
the
improve-server-typeing
branch
from
dc44f6e
to
9e2686f
Compare
|
@tobyS this would be my proposal for the Server Typing, what do you think about it :)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lukas Kämmerling lukas.kaemmerling@hetzner-cloud.de
This came up in #62 . Basically it is a "breaking" change, as the type structure is changed. But i would like to "sit this change out", because it improves the quality and autocompletion significant. So i would like to do this as a Minor release then.