-
Notifications
You must be signed in to change notification settings - Fork 76
feat: add TEST_TIMEOUT
for tests
#533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TEST_TIMEOUT
for tests
#533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left A comment on return type. Can we also add TEST_TIMEOUT
to the .env.sample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing -- would like the default timeout to be a bit longer than the timeout for running a LIT action on the nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Rock on man, nice work 💖
Description
This PR ensures that a test will time out if it ever gets stuck, allowing the test runner to continue running and produce a test report.
Note: We are in the process of migrating to Jest, but this fix is required to ensure smooth testing in the meantime.