Skip to content

feat: add TEST_TIMEOUT for tests #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Jul 12, 2024

Description

This PR ensures that a test will time out if it ever gets stuck, allowing the test runner to continue running and produce a test report.

Note: We are in the process of migrating to Jest, but this fix is required to ensure smooth testing in the meantime.

@Ansonhkg Ansonhkg requested a review from MaximusHaximus July 12, 2024 11:30
@Ansonhkg Ansonhkg requested a review from joshLong145 as a code owner July 12, 2024 11:30
Copy link

@joshLong145 joshLong145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left A comment on return type. Can we also add TEST_TIMEOUT to the .env.sample

@joshLong145 joshLong145 self-requested a review July 15, 2024 12:47
Copy link
Contributor

@MaximusHaximus MaximusHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing -- would like the default timeout to be a bit longer than the timeout for running a LIT action on the nodes.

@Ansonhkg Ansonhkg requested a review from MaximusHaximus July 15, 2024 18:28
Copy link
Contributor

@MaximusHaximus MaximusHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Rock on man, nice work 💖

@MaximusHaximus MaximusHaximus merged commit fb77647 into master Jul 15, 2024
4 checks passed
@MaximusHaximus MaximusHaximus deleted the feature/lit-3598-js-sdk-make-tinny-test-timeout branch July 15, 2024 22:07
@Ansonhkg Ansonhkg mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants