refactor: parallelize invariants (foundry-rs#5676)

* refactor: parallelize invariants

* chore: clippy

* collect before

Author: DaniPopes

crates/evm/src/executor/inspector/cheatcodes/mod.rs

@@ -217,7 +217,6 @@ impl Cheatcodes {
         // but only if the backend is in forking mode
         data.db.ensure_cheatcode_access_forking_mode(caller)?;
 
-        // TODO: Log the opcode for the debugger
         let opt = env::apply(self, data, caller, &decoded)
             .transpose()
             .or_else(|| util::apply(self, data, &decoded))

crates/evm/src/fuzz/invariant/error.rs

@@ -41,17 +41,18 @@ impl InvariantFuzzError {
         calldata: &[BasicTxDetails],
         call_result: RawCallResult,
         inner_sequence: &[Option<BasicTxDetails>],
-        shrink_sequence: bool,
+        shrink: bool,
     ) -> Self {
-        let mut func = None;
-        let origin: String;
-
-        if let Some(f) = error_func {
-            func = Some(f.short_signature().into());
-            origin = f.name.clone();
+        let (func, origin) = if let Some(f) = error_func {
+            (Some(f.short_signature().into()), f.name.as_str())
         } else {
-            origin = "Revert".to_string();
-        }
+            (None, "Revert")
+        };
+        let revert_reason = decode_revert(
+            call_result.result.as_ref(),
+            Some(invariant_contract.abi),
+            Some(call_result.exit_reason),
+        );
 
         InvariantFuzzError {
             logs: call_result.logs,
@@ -60,29 +61,20 @@ impl InvariantFuzzError {
                 format!(
                     "{}, reason: '{}'",
                     origin,
-                    match decode_revert(
-                        call_result.result.as_ref(),
-                        Some(invariant_contract.abi),
-                        Some(call_result.exit_reason)
-                    ) {
-                        Ok(e) => e,
+                    match &revert_reason {
+                        Ok(s) => s.clone(),
                         Err(e) => e.to_string(),
                     }
                 )
                 .into(),
                 calldata.to_vec(),
             ),
             return_reason: "".into(),
-            revert_reason: decode_revert(
-                call_result.result.as_ref(),
-                Some(invariant_contract.abi),
-                Some(call_result.exit_reason),
-            )
-            .unwrap_or_default(),
+            revert_reason: revert_reason.unwrap_or_default(),
             addr: invariant_contract.address,
             func,
             inner_sequence: inner_sequence.to_vec(),
-            shrink: shrink_sequence,
+            shrink,
         }
     }