Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should accept jsonc for package #993

Closed
gruvw opened this issue Aug 29, 2023 · 2 comments
Closed

Should accept jsonc for package #993

gruvw opened this issue Aug 29, 2023 · 2 comments

Comments

@gruvw
Copy link

gruvw commented Aug 29, 2023

Currently, "VSCode-like" snippets require a package.json file to be in the snippets' directory.

However, LuaSnip should also accept package.jsonc instead as it is sometimes practical to add comments, and for consistency (as it already accepts jsonc for snippets definition).
@L3MON4D3
Copy link
Owner

Oh yeah, definitely 👍

@L3MON4D3
Copy link
Owner

L3MON4D3 commented Dec 2, 2023

Ah, fixed in #1033!

@L3MON4D3 L3MON4D3 closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@L3MON4D3 @gruvw