-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari scroll bouncing causes white space to appear #195
Comments
The same is happening to me on Safari. Using the latest react-headroom release 3.1.0 as well as 2.2.8. |
We also have been experiencing this for a few months now. Observed that is wasn't an issue in Safari 13, only in 14. |
I'm starting to think that it's a Safari glitch, not related to the library itself. |
@cheezywhiz Can you share how you got isSafari and isMobile? |
@meaghanbass I'm using https://www.npmjs.com/package/react-device-detect for that |
I was seeing the same issue but was able to get this working by passing in <Headroom style={{ zIndex: 100, position: "fixed" }}>
...
</Headroom> |
@smeriwether amazing! confirming that this works. thanks!! |
Struck by the same problem in production. Setting position fixed solves it, but ruins all the "animations" on the header, which kinda moots the point of using headroom for having a visually pleasing behaving header. Have anyone found any other fixes to this? |
Is this still happening with v3.1.1? |
seems to work fine now with 3.1.1 |
Yes, this is solved now. Thanks guys! |
This is still a problem with react-headroom 3.2.0 in Safari. |
Hello @chaddjohnson please could you let me know what version of Safari you're on |
@endymion1818 Version 15.1 (17612.2.9.1.20) BTW, is your username a Hyperion reference? |
Ok thanks. Yes it is! I've been fascinated with John Keats ever since I read Dan Simmons' novels some years ago. |
This is still an issue with react-headroom 3.2.0 and Safari 15.4 (17613.1.17.1.13) |
Well, darnit. |
When scrolling too fast or too much to the top of the page in desktop Safari, it shows an extra white space as is expected, but that locks the header out of place, as can be seen in the image below (notice the highlighted element is actually below the highlight).
Does anyone knows a way to fix this? Seems related to #89.
Edit: just saw that #90 aimed to fix this but it still happens to me on 3.1.0
The text was updated successfully, but these errors were encountered: