Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en: docgen #116

Merged
merged 2 commits into from
Sep 20, 2022
Merged

en: docgen #116

merged 2 commits into from
Sep 20, 2022

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Sep 19, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references:

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

ref/cli/kcl/docgen

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@He1pa He1pa requested a review from a team September 19, 2022 07:28
@He1pa He1pa changed the title feat: translate docgen [WIP] feat: translate docgen Sep 19, 2022
@He1pa He1pa changed the title [WIP] feat: translate docgen feat: translate docgen Sep 19, 2022
@He1pa He1pa mentioned this pull request Sep 19, 2022
16 tasks
@He1pa He1pa changed the title feat: translate docgen en: docgen Sep 20, 2022
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chai2010 chai2010 merged commit 117e85c into main Sep 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2022
@He1pa He1pa deleted the docgen branch September 22, 2022 03:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants