Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic defaults tests #375

Closed
Tracked by #369
martinhesko opened this issue Apr 12, 2024 · 1 comment · Fixed by #490
Closed
Tracked by #369

Atomic defaults tests #375

martinhesko opened this issue Apr 12, 2024 · 1 comment · Fixed by #490
Assignees
Labels
Service Protection Issues for Service Protection tests Test case New test case

Comments

@martinhesko
Copy link
Contributor

martinhesko commented Apr 12, 2024

Summary

The kuadrant operator now allows defaults to be set for AuthPolicy and RateLimitPolicy. Test that these defaults work properly and are mutually exclusive with setting policy in spec.

Documentation

Implementing PRs: Kuadrant/kuadrant-operator#503, Kuadrant/kuadrant-operator#456, Kuadrant/kuadrant-operator#536
RFC: https://github.com/Kuadrant/architecture/blob/main/rfcs/0009-defaults-and-overrides.md

Test cases

Repeat each for AuthPolicy and RateLimitPolicy

  • Tests functionality of rules set within the defaults block

    • Set HTTPRoute attached policy with an explicit defaults block
    • verify the policy inside the defaults block functions as a normal policy
  • Test mutual exclusivity of defaults block with other rules

    • set HTTPRoute attached policy configured both with regular config and config inside a defaults block
    • Check that policy is rejected due to Implicit and explicit defaults are mutually exclusive
  • Test policy inheritability and PolicyAffected condition

    • Attach a policy with a configured defaults block to your gateway
    • Check the status of the gateway's HTTPRoute
    • status should specify Object affected by {Auth|RateLimit}Policy x
    • Curl the route to verify the policy attached to gateway got applied to your HTTPRoute
  • Test policy discoverability

    • Attach a policy with a configured defaults block to your gateway
    • Create a new HTTPRoute attached to your gateway
    • Check HTTPRoute status, it should specify Object affected by {Auth|RateLimit}Policy x
    • Curl the route to verify the policy attached to gateway got applied to your HTTPRoute
@martinhesko martinhesko mentioned this issue Apr 12, 2024
2 tasks
@martinhesko martinhesko added Test case New test case Service Protection Issues for Service Protection tests labels Apr 12, 2024
@averevki averevki self-assigned this May 28, 2024
@averevki
Copy link
Contributor

@martinhesko how do 2 last test cases differ from each other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Service Protection Issues for Service Protection tests Test case New test case
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants