Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate running the gateway API conformance tests against the hub gateway #625

Closed
pmccarthy opened this issue Oct 12, 2023 · 6 comments
Assignees
Labels

Comments

@pmccarthy
Copy link
Contributor

pmccarthy commented Oct 12, 2023

What

Read https://gateway-api.sigs.k8s.io/concepts/conformance/#3-conformance-tests

GWAPI version is currently 0.6.1

Attempt to execute these against a hub defined gateway

Done

  • Tests executed fully (failures are fine)
  • Document / provide script so that anyone can execute them
@maksymvavilov
Copy link
Contributor

@maksymvavilov
Copy link
Contributor

maksymvavilov commented Nov 30, 2023

The short description of results: tests should be modified (there is a commit in my fork of gw API with all the modifications) but they still fail at the very first real check - we don't have conditions on our listeners and this promts fails on all the tests for the "base" aka Gateway subset of tests.

@laurafitzgerald
Copy link
Contributor

@makslion out of interest moreso what triggered the change sed 's/gateway-conformance/gw-conf/' in the above commit? It seems to be the bulk of the changes there.

@maksymvavilov
Copy link
Contributor

maksymvavilov commented Dec 1, 2023

@makslion out of interest moreso what triggered the change sed 's/gateway-conformance/gw-conf/' in the above commit? It seems to be the bulk of the changes there.

This is how we create manifestwork name and it end up being a label here . There is a limit for character length for labels and using a "long" namespace were exceeding that every time. I'm still cathing specific gateways created by suite that exceeds 63 characters

@maksymvavilov
Copy link
Contributor

Note that conformance tests are a bit funky right now. There is a GEP about it, so, hopefully, it will be a more pleasant experience running them.

@maksymvavilov
Copy link
Contributor

closing this issue. Seems like people are satisfied with the investigation that was done and the first "follow-up" issue was created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

3 participants