no_parens_one_expr #122
Merged
no_parens_one_expr #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test prior to adding matchedExpression as valid argument.
Red tests for quoting.
When a variable is the identifier only the variable name should be used as the quoted identifier as the nil argument in a variable quoted form needs to be replaced by the quotedArguments for the matchedCallOperation.
`decimalFloat decimalFloat` is invalid in both Elixir and intellij-elixir, but other arguments are allowed in intellij-elixir.
Use Run Before settings in configuration instead of having to manually start intellij_elixir release.
Complete no_parens_one_expr porting. Atom keywords, char list lines, and string lines can now be used as relative identifiers, in addition to the operators and identifiers previously supported. Parentheses can be used for normal function calls in addition to dot calls. In order to prevent `one + two` being parsed as `one(+two)`, a SIGNIFICANT_WHITE_SPACE token had to be introduced after DUAL_OPERATOR. This is similar to :elixir_tokenizer.handle_space_sensitive_tokens/4. parenthesesArguments are allowed to repeat once to handle `def unquote(variable)(arguments)`.
matchedCallOperation was split into matchedQualifiedCallOperation and matchedUnqualifiedCallOperation.
Labelling it just "" made it really hard to debug.
Lexer generates CALL between identifier and `(`, so for both uses of matchedCallArguments, CALL must be consumed before OPENING_PARENTHESIS.
Adding CALL before parenthesesArguments in matchedCallArguments fixed the qualified and unqualified call testData.
Parsing is slightly farther. It gets up to the first `do`.
KronicDeth
added a commit
that referenced
this pull request
May 6, 2015
KronicDeth
added a commit
that referenced
this pull request
May 6, 2015
This was referenced May 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #60