Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST /links inconsistent "description" field type and uneffective "check_disabled" #646

Closed
Alfablos opened this issue May 11, 2023 · 0 comments · Fixed by #652
Closed

POST /links inconsistent "description" field type and uneffective "check_disabled" #646

Alfablos opened this issue May 11, 2023 · 0 comments · Fixed by #652
Labels
Bug Something isn't working

Comments

@Alfablos
Copy link

Alfablos commented May 11, 2023

Bug Description

Hi,
I really appreciate you work and the app is awesome. However I've found a couple of issues.

I was building a small rust client to migrate my bookmarks from confluence, however I got a serialization error while working on the "description" field: apparently whenever the description is empty (empty string as per docs) in the post request the response contains a boolean false for that field.

Also, the "check_disabled" field is reported as true when set to false in the request.

I was also wondering if there were a way to override the Laravel rate limiter, I believe I can only perform 60 rpm.

I'm attaching a couple of screenshots to show the issue.

How to reproduce

POST /api/v1/links

{
    "url": "https://duckduckgoooooo.com",
    "title": "DuckDuckGo — Privacy, simplified.",
    "description": "",
    "lists": [],
    "tags": [],
    "is_private": true,
    "check_disabled": true
}

Expected behavior

200/Ok or 201/Created

{
    "url": "https://duckduckgoooooo.com",
    "title": "DuckDuckGo — Privacy, simplified.",
    "description": "",
    "is_private": true,
    "check_disabled": true,
    "user_id": 1,
    "icon": "link",
    "thumbnail": null,
    "status": 3,
    "updated_at": "2023-05-11T12:31:40.000000Z",
    "created_at": "2023-05-11T12:31:40.000000Z",
    "id": 5,
    "tags": [],
    "lists": []
}

Logs

No response

Screenshots

linkace-post-nodescr
linkace-post-descr

LinkAce version

1.12.0

Setup Method

Docker

Operating System

Linux (Ubuntu, CentOS,...)

Client details

➜  docker version
Client:
 Version:           23.0.4
 OS/Arch:           linux/amd64


Server:
 Engine:
  Version:          23.0.4
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.7.0
 runc:
  Version:          1.1.7
@Alfablos Alfablos added the Bug Something isn't working label May 11, 2023
@Kovah Kovah linked a pull request Jun 4, 2023 that will close this issue
@Kovah Kovah closed this as completed in #652 Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant