Skip to content

Commit dc46b70

Browse files
committed
remove JsonArrayBuilder addAll varargs JsonElement util
1 parent ec87d84 commit dc46b70

File tree

2 files changed

+4
-41
lines changed

2 files changed

+4
-41
lines changed

formats/json-tests/commonTest/src/kotlinx/serialization/json/JsonBuildersTest.kt

Lines changed: 4 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,8 @@ class JsonBuildersTest {
6868
)
6969

7070
assertEquals(
71-
"""[1,"a",false,null,2,"b",true,null]""",
71+
"""[2,"b",true,null]""",
7272
buildJsonArray {
73-
assertTrue {
74-
addAll(
75-
JsonPrimitive(1),
76-
JsonPrimitive("a"),
77-
JsonPrimitive(false),
78-
JsonNull,
79-
)
80-
}
8173
assertTrue {
8274
addAll(
8375
listOf(
@@ -92,16 +84,8 @@ class JsonBuildersTest {
9284
)
9385

9486
assertEquals(
95-
"""[{},{},{},null,{},{},{},null]""",
87+
"""[{},{},{},null]""",
9688
buildJsonArray {
97-
assertTrue {
98-
addAll(
99-
JsonObject(emptyMap()),
100-
JsonObject(emptyMap()),
101-
JsonObject(emptyMap()),
102-
JsonNull,
103-
)
104-
}
10589
assertTrue {
10690
addAll(
10791
listOf(
@@ -116,16 +100,8 @@ class JsonBuildersTest {
116100
)
117101

118102
assertEquals(
119-
"""[[],[],[],null,[],[],[],null]""",
103+
"""[[],[],[],null]""",
120104
buildJsonArray {
121-
assertTrue {
122-
addAll(
123-
JsonArray(emptyList()),
124-
JsonArray(emptyList()),
125-
JsonArray(emptyList()),
126-
JsonNull,
127-
)
128-
}
129105
assertTrue {
130106
addAll(
131107
listOf(
@@ -140,11 +116,8 @@ class JsonBuildersTest {
140116
)
141117

142118
assertEquals(
143-
"""[null,null,null,null]""",
119+
"""[null,null]""",
144120
buildJsonArray {
145-
assertTrue {
146-
addAll(JsonNull, JsonNull)
147-
}
148121
assertTrue {
149122
addAll(listOf(JsonNull, JsonNull))
150123
}

formats/json/commonMain/src/kotlinx/serialization/json/JsonElementBuilders.kt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -198,16 +198,6 @@ public fun JsonArrayBuilder.addJsonObject(builderAction: JsonObjectBuilder.() ->
198198
public fun JsonArrayBuilder.addJsonArray(builderAction: JsonArrayBuilder.() -> Unit): Boolean =
199199
add(buildJsonArray(builderAction))
200200

201-
/**
202-
* Adds the given JSON [elements] to a resulting JSON array.
203-
*
204-
* @return `true` if the list was changed as the result of the operation.
205-
*/
206-
@ExperimentalSerializationApi
207-
public fun JsonArrayBuilder.addAll(vararg elements: JsonElement): Boolean {
208-
return addAll(elements.toList())
209-
}
210-
211201
/** Adds the given string [values] to a resulting JSON array. */
212202
@JvmName("addAllStrings")
213203
@ExperimentalSerializationApi

0 commit comments

Comments
 (0)