Apply suggestions from code review

shanshin · sandwwraith · web-flow · commit bbef37337aad · 2024-08-23T17:18:04.000+02:00
Co-authored-by: Leonid Startsev &lt;sandwwraith@users.noreply.github.com&gt;
diff --git a/formats/protobuf/commonMain/src/kotlinx/serialization/protobuf/internal/Helpers.kt b/formats/protobuf/commonMain/src/kotlinx/serialization/protobuf/internal/Helpers.kt
@@ -111,7 +111,7 @@ internal fun extractProtoId(descriptor: SerialDescriptor, index: Int, zeroBasedD
 
 private fun checkFieldNumber(fieldNumber: Int, descriptor: SerialDescriptor) {
     if (fieldNumber <= 0) {
-        throw SerializationException("$fieldNumber is not allowed in ProtoNumber for ${descriptor.serialName}, because protobuf support field values in range 1..2147483647")
+        throw SerializationException("$fieldNumber is not allowed in ProtoNumber for ${descriptor.serialName}, because protobuf support field numbers in range 1..${Int.MAX_VALUE}}")
     }
 }
 
diff --git a/formats/protobuf/commonMain/src/kotlinx/serialization/protobuf/internal/ProtobufDecoding.kt b/formats/protobuf/commonMain/src/kotlinx/serialization/protobuf/internal/ProtobufDecoding.kt
@@ -48,7 +48,7 @@ internal open class ProtobufDecoder(
              *
              * Since the library allows the use of fields with proto ID 0,
              * it is necessary to initialize all elements, because there will always be one extra element
-             * in the fast path array, which misses in the descriptor
+             * in the fast path array, which is missing from the descriptor
              */
             val cache = IntArray(elements + 1) { -1 }
             for (i in 0 until elements) {

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ internal fun extractProtoId(descriptor: SerialDescriptor, index: Int, zeroBasedD`
`111`	`111`
`112`	`112`	`private fun checkFieldNumber(fieldNumber: Int, descriptor: SerialDescriptor) {`
`113`	`113`	`if (fieldNumber <= 0) {`
`114`		`- throw SerializationException("$fieldNumber is not allowed in ProtoNumber for ${descriptor.serialName}, because protobuf support field values in range 1..2147483647")`
	`114`	`+ throw SerializationException("$fieldNumber is not allowed in ProtoNumber for ${descriptor.serialName}, because protobuf support field numbers in range 1..${Int.MAX_VALUE}}")`
`115`	`115`	`}`
`116`	`116`	`}`
`117`	`117`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ internal open class ProtobufDecoder(`
`48`	`48`	`*`
`49`	`49`	`* Since the library allows the use of fields with proto ID 0,`
`50`	`50`	`* it is necessary to initialize all elements, because there will always be one extra element`
`51`		`- * in the fast path array, which misses in the descriptor`
	`51`	`+ * in the fast path array, which is missing from the descriptor`
`52`	`52`	`*/`
`53`	`53`	`val cache = IntArray(elements + 1) { -1 }`
`54`	`54`	`for (i in 0 until elements) {`