Skip to content

Reduce unnecessary @PublishedApi surface of UnbiasedSelectBuilderImpl #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Reduce unnecessary @PublishedApi surface of UnbiasedSelectBuilderImpl #3371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9ebe59
Reduce unnecessary @PublishedApi surface of UnbiasedSelectBuilderImpl
qwwdfsad Jul 15, 2022
c802272
~
qwwdfsad Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions kotlinx-coroutines-core/api/kotlinx-coroutines-core.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,8 +1259,6 @@ public final class kotlinx/coroutines/selects/SelectUnbiasedKt {

public final class kotlinx/coroutines/selects/UnbiasedSelectBuilderImpl : kotlinx/coroutines/selects/SelectBuilder {
public fun <init> (Lkotlin/coroutines/Continuation;)V
public final fun getClauses ()Ljava/util/ArrayList;
public final fun getInstance ()Lkotlinx/coroutines/selects/SelectBuilderImpl;
public final fun handleBuilderException (Ljava/lang/Throwable;)V
public final fun initSelectResult ()Ljava/lang/Object;
public fun invoke (Lkotlinx/coroutines/selects/SelectClause0;Lkotlin/jvm/functions/Function1;)V
Expand Down
10 changes: 6 additions & 4 deletions kotlinx-coroutines-core/common/src/selects/SelectUnbiased.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@ public suspend inline fun <R> selectUnbiased(crossinline builder: SelectBuilder<


@PublishedApi
internal class UnbiasedSelectBuilderImpl<in R>(uCont: Continuation<R>) :
SelectBuilder<R> {
val instance = SelectBuilderImpl(uCont)
val clauses = arrayListOf<() -> Unit>()
internal class UnbiasedSelectBuilderImpl<in R>(
uCont: Continuation<R>
) : SelectBuilder<R> {

private val instance = SelectBuilderImpl(uCont)
private val clauses = arrayListOf<() -> Unit>()

@PublishedApi
internal fun handleBuilderException(e: Throwable): Unit = instance.handleBuilderException(e)
Expand Down