Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample operator with emitLast argument #2149

Open
gildor opened this issue Jul 20, 2020 · 0 comments
Open

sample operator with emitLast argument #2149

gildor opened this issue Jul 20, 2020 · 0 comments

Comments

@gildor
Copy link
Contributor

gildor commented Jul 20, 2020

Existing sample operator doesn't emit last emitted value on completion, which makes it not useful for streams which emit a final value as last element before complete. On my practice it used often for such things as a stream which represent progress and final result (when sealed class Progress|Success is emitted)

I propose to add emitLast argument with default value false to sample operator, so it will allow supporting this use case.

This behavior already exist in RxJava2, see related issue for RxJava2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants