Partially apply recommendations for improving DSL #625
Conversation
| /** | ||
| * Instance to configuring of report variants shared by the current project. | ||
| * | ||
| * See details in [currentProject]. |
There was a problem hiding this comment.
Since KDoc doesn't have any syntax for overloads, I'm afraid that [currentProject] will link recursively to this property again (it doesn't do this in IDEA currently, but who knows). Maybe just say See details in [currentProject] function or See details in [KoverCurrentProjectVariantsConfig]?
There was a problem hiding this comment.
In dokka when you click on the currentProject property, the function opens %)
So, it seems to me that this postscript is more for the IDE.
| internal var instrumentationAction: Action<KoverMergingInstrumentation>? = null | ||
| internal val variantsAction: MutableMap<String, Action<KoverMergingVariantCreate>> = mutableMapOf() | ||
|
|
||
| internal var configured: Boolean = false |
There was a problem hiding this comment.
I think some test is needed for this new boolean property, with e.g., kover.merge.subprojects() in configuration
There was a problem hiding this comment.
It's already tested, see tests in MergingTests, e.g. testRootNoProjects (error should be thrown)
There was a problem hiding this comment.
I mean you need to test that syntax kover.merge.subprojects works the same as kover { merge { subprojects() } }
The new DSL will allow to write chains like `kover.reports.total { ... }` instead of `kover { reports { total { ... } } }`.
However, the DomainObjectContainer for variants has not been implemented, because it will be necessary to rework the workflow with different types of variants, which is part of a larger reworking of the DSL.
Resolves #600
The new DSL will allow to write chains like
kover.reports.total { ... }instead ofkover { reports { total { ... } } }.However, the DomainObjectContainer for variants has not been implemented, because it will be necessary to rework the workflow with different types of variants, which is part of a larger reworking of the DSL.
Resolves #600