Added LocalTime.Formats.ISO_BASIC (ISO 8601 basic format) #518
Conversation
|
ISO 8601 specifies that the format for time-of-day includes a leading |
|
You are right, thanks for spotting this! I believe the same should also apply to LocalTime.Formats.ISO. Should I attempt to change it as well? |
The extended ISO format is allowed to omit the In fact, regarding usefulness: is |
|
I find it very useful, for example if one need to have a timestamp stored in a file name, in my case |
| @@ -279,6 +279,23 @@ internal class LocalTimeFormat(override val actualFormat: CachedFormatStructure< | |||
| } | |||
|
|
|||
| // these are constants so that the formats are not recreated every time they are used | |||
| internal val ISO_TIME_BASIC by lazy { | |||
| LocalTimeFormat.build { | |||
| char('T') | |||
There was a problem hiding this comment.
Please see internal val ISO_DATETIME: our format is case-insensitive.
| * | ||
| * @sample kotlinx.datetime.test.samples.LocalTimeSamples.Formats.isoBasic | ||
| */ | ||
| public val ISO_BASIC: DateTimeFormat<LocalTime> |
There was a problem hiding this comment.
Please also add tests. Examples: LocalDateTimeFormatTest#testIso, LocalDateFormatTest#testBasicIso, etc.
core/common/src/LocalTime.kt
Outdated
| /** | ||
| * ISO 8601 basic format. | ||
| * | ||
| * Examples: `1234`, `123456`, `123456.789`, `123456.1234`. |
There was a problem hiding this comment.
These examples are not valid for this format.
|
Should be complete now! |
core/common/src/LocalDateTime.kt
Outdated
| * When formatting, seconds are included, only if they are non-zero. | ||
| * Fractional parts of the second are included if non-zero. | ||
| * | ||
| * See ISO-8601-1:2019, 5.4.2.1b), the version without the offset, together with |
There was a problem hiding this comment.
| * See ISO-8601-1:2019, 5.4.2.1b), the version without the offset, together with | |
| * See ISO-8601-1:2019, 5.4.2.1a), the version without the offset, together with |
b) is the extended format.
| * | ||
| * When formatting, seconds are always included, even if they are zero. | ||
| * Fractional parts of the second are included if non-zero. | ||
| * |
There was a problem hiding this comment.
I think LocalDateTime.ISO_BASIC is also worth mentioning (given that you personally were interested in LocalDateTime.Formats.ISO_BASIC, for example).
| optional { | ||
| second() | ||
| } | ||
| optional { | ||
| char('.') | ||
| secondFraction(1, 9) | ||
| } | ||
| } |
There was a problem hiding this comment.
| optional { | |
| second() | |
| } | |
| optional { | |
| char('.') | |
| secondFraction(1, 9) | |
| } | |
| } | |
| optional { | |
| second() | |
| optional { | |
| char('.') | |
| secondFraction(1, 9) | |
| } | |
| } | |
| } |
As the tests show, otherwise, 12:30:00.123 gets formatted as T1230.123, which is not valid: fractions of a second are only emitted together with the second value itself, even if it is zero.
… itself, even if it is zero.
|
Thanks for your careful review! |
No description provided.