Refactor assertOffsetInfoType to directly compare OffsetInfo types for improved clarity in TimeZoneNativeTest.

DmitryNekrasov · DmitryNekrasov · commit bfc1725e0167 · 2025-06-30T18:11:15.000+04:00
diff --git a/core/darwin/test/TimeZoneNativeTest.kt b/core/darwin/test/TimeZoneNativeTest.kt
@@ -381,12 +381,12 @@ class TimeZoneNativeTest {
     }
 
     private fun assertOffsetInfoType(info: OffsetInfo, expectedType: OffsetInfoType) {
-        val expectedClass = when (expectedType) {
-            REGULAR -> OffsetInfo.Regular::class
-            GAP -> OffsetInfo.Gap::class
-            OVERLAP -> OffsetInfo.Overlap::class
+        val actualType = when (info) {
+            is OffsetInfo.Regular -> REGULAR
+            is OffsetInfo.Gap -> GAP
+            is OffsetInfo.Overlap -> OVERLAP
         }
-        assertEquals(expectedClass, info::class)
+        assertEquals(expectedType, actualType)
     }
 
     private fun formatHeader(zoneId: String, preferredLength: Int = 75): String {

Original file line number	Diff line number	Diff line change
`@@ -381,12 +381,12 @@ class TimeZoneNativeTest {`
`381`	`381`	`}`
`382`	`382`
`383`	`383`	`private fun assertOffsetInfoType(info: OffsetInfo, expectedType: OffsetInfoType) {`
`384`		`- val expectedClass = when (expectedType) {`
`385`		`- REGULAR -> OffsetInfo.Regular::class`
`386`		`- GAP -> OffsetInfo.Gap::class`
`387`		`- OVERLAP -> OffsetInfo.Overlap::class`
	`384`	`+ val actualType = when (info) {`
	`385`	`+ is OffsetInfo.Regular -> REGULAR`
	`386`	`+ is OffsetInfo.Gap -> GAP`
	`387`	`+ is OffsetInfo.Overlap -> OVERLAP`
`388`	`388`	`}`
`389`		`- assertEquals(expectedClass, info::class)`
	`389`	`+ assertEquals(expectedType, actualType)`
`390`	`390`	`}`
`391`	`391`
`392`	`392`	`private fun formatHeader(zoneId: String, preferredLength: Int = 75): String {`