Compiler plugin read improvements #949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
added
the
Compiler plugin
zaleslaw
reviewed
Nov 13, 2024
| @@ -14,7 +14,7 @@ import org.jetbrains.kotlinx.dataframe.plugin.impl.toPluginDataFrameSchema | |||
| class FlattenDefault : AbstractSchemaModificationInterpreter() { | |||
| val Arguments.receiver by dataFrame() | |||
| val Arguments.keepParentNameForColumns: Boolean by arg(defaultValue = Present(false)) | |||
| val Arguments.separator: String by arg(defaultValue = Present(".")) | |||
| val Arguments.separator: String by arg(defaultValue = Present("_")) | |||
There was a problem hiding this comment.
is this reflects our new convention about separator in column names?
zaleslaw
approved these changes
Nov 13, 2024
Jolanrensen
approved these changes
Nov 14, 2024
| } | ||
|
|
||
| private fun resolveFile(resolutionPath: String?, path: String): File? { | ||
| return resolutionPath?.let { | ||
| private fun tryResolveFile(resolutionPath: String?, path: String): DataSource { |
There was a problem hiding this comment.
isn't this duplicate logic to in the :core module? (or it probably should be)
There was a problem hiding this comment.
No, it's plugin-specific. It's to handle relative path arguments like read("file.csv") when project configuration provides resolutionPath - directory where relative files are expected to be
Usual DataFrame.read implicitly relies on working directory of JVM to resolve relative files, which for compiler process is somewhere outside project directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a series of bug fixes and tests, no new fancy features