-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
describe()
fixes
#937
Open
Jolanrensen
wants to merge
15
commits into
master
Choose a base branch
from
statistics-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
describe()
fixes
#937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
force-pushed
the
statistics-fixes
branch
2 times, most recently
from
November 7, 2024 13:56
dc4687d
to
6e028f1
Compare
… to either double or bigdecimal) and added tests
…oes. (It kept confusing me)
Jolanrensen
force-pushed
the
statistics-fixes
branch
from
November 8, 2024 11:49
0156765
to
966447d
Compare
…ng them to either double or bigdecimal) and added tests
Jolanrensen
force-pushed
the
statistics-fixes
branch
from
November 8, 2024 14:52
945fb49
to
b2bdb4a
Compare
…ng rule as it was a bit too aggressive
Jolanrensen
force-pushed
the
statistics-fixes
branch
from
November 13, 2024 11:10
ff306f9
to
c8de339
Compare
Jolanrensen
force-pushed
the
statistics-fixes
branch
from
November 15, 2024 12:18
ba1761c
to
ea4d035
Compare
Jolanrensen
requested review from
zaleslaw and
koperagen
and removed request for
zaleslaw
November 15, 2024 12:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352 and part of #558
I'll first fix some of the most annoying bugs which can be found with
describe()
, more changes or fixes will come later.Fixed:
col.isInterComparable()
instead ofcol.isComparable()
to avoid confusion@DataSchema
type being String instead of KType