describe() fixes#937
Conversation
dc4687d to
6e028f1
Compare
… to either double or bigdecimal) and added tests
…oes. (It kept confusing me)
0156765 to
966447d
Compare
…ng them to either double or bigdecimal) and added tests
945fb49 to
b2bdb4a
Compare
…ng rule as it was a bit too aggressive
ff306f9 to
c8de339
Compare
ba1761c to
ea4d035
Compare
|
Could you please add a test for #352? Maybe even if something else covers it, good to have one that is closer to use case |
| * the type argument not being [Nothing]. | ||
| */ | ||
| public fun AnyCol.isComparable(): Boolean = | ||
| public fun AnyCol.isInterComparable(): Boolean = |
There was a problem hiding this comment.
isInterComparable is a new / not widespread term, for me it raises some questions like what's the difference (if i were to see it for the first time)
For users isComparable can be described as "filter columns for which max(), min(), median() and other (we actually only have 3) order operations make sense"
You wouldn't expect to find max() value for mixed column of String and Double values, so it should make things clearer
There was a problem hiding this comment.
Well, that's actually the reason I changed it, because for me isComparable can be interpreted in two ways:
- "is comparable": so can call max(), min(), etc., not true for mixed number columns
- "is
Comparable"; implements the interface, which would be true for mixed number columns
you need KDocs to explain what it actually means (and past-me didn't do a good job at that either). inter-comparable means "comparable inside" (or something, I came up with it too), which narrows down the meaning to the first. Of course, other name suggestions are very welcome if you can think of any :)
There was a problem hiding this comment.
With suggestion of ChatGPT I'll rename it to .valuesAreComparable(). Would that be okay?
Very good comment. After I added a test I noticed this PR didn't actually fully fix #352. It just fixed the error message. The actual issue needs to be solved separately. I will reorganize things a bit |
96ed593 to
36fd883
Compare
Fixes #558 : Describe breaks on
NumbercolumnI'll first fix some of the most annoying bugs which can be found with
describe(), more changes or fixes will come later.Fixed:
col.isInterComparable()instead ofcol.isComparable()to avoid confusion@DataSchematype being String instead of KType