-
Notifications
You must be signed in to change notification settings - Fork 73
Avoiding to use the URL-encoded path #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Running CI on https://github.com/Kotlin/dataframe/tree/Kantis-fix-path-with-spaces. Thanks! |
@Jolanrensen what was the failure? 🙂 |
@Kantis I suspect KSP has problems reading the new path. You can run the tests yourself locally with 4 failed tests in org.jetbrains.dataframe.ksp.DataFrameSymbolProcessorTest:
|
Instead, we convert the URL to a URI and use the File-constructor which takes a URI argument directly.
5f66ae7
to
fc63076
Compare
Thanks, I missed that the CSV was referred to from another place. Fixed 👍🏼 |
Instead, we convert the URL to a URI and use the File-constructor which takes a URI argument directly.
fixes #356