Disable large logs in tests for FastDoubleParser
#1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_LOGS in tests to show turn them on the relevant tests when needed
Jolanrensen
added
the
infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastDoubleParserused to show many annoying logs in our tests.FastDoubleParserwill now log at the lowesttracelevel. Since our tests only show logs fordebugor higher, they won't show up anywhere anymore.Added
SHOW_LOGSconstant to relevant tests if we ever do need to view the logs forFastDoubleParser.Users will likely never see the logs, but they can make them visible by setting their own global log level to
trace(or specifically for the class:org.slf4j.simpleLogger.log.org.jetbrains.kotlinx.dataframe.impl.io.FastDoubleParser=trace)