Skip to content

Commit 0c66782

Browse files
committed
cleaned samples/api files and made sure ktlint will ignore them in the future
1 parent 813d270 commit 0c66782

File tree

16 files changed

+297
-193
lines changed

16 files changed

+297
-193
lines changed

core/build.gradle.kts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,14 +102,6 @@ tasks.withType<KspTask> {
102102
}
103103
}
104104

105-
tasks.named("runKtlintCheckOverSamplesSourceSet") {
106-
onlyIf { false }
107-
}
108-
109-
tasks.named("runKtlintFormatOverSamplesSourceSet") {
110-
onlyIf { false }
111-
}
112-
113105
val clearTestResults by tasks.creating(Delete::class) {
114106
delete(layout.buildDirectory.dir("dataframes"))
115107
delete(layout.buildDirectory.dir("korroOutputLines"))

core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Access.kt

Lines changed: 53 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,58 @@
1+
@file:Suppress("ktlint")
2+
13
package org.jetbrains.kotlinx.dataframe.samples.api
24

3-
import org.jetbrains.kotlinx.dataframe.api.*
5+
import org.jetbrains.kotlinx.dataframe.api.add
6+
import org.jetbrains.kotlinx.dataframe.api.after
7+
import org.jetbrains.kotlinx.dataframe.api.chunked
8+
import org.jetbrains.kotlinx.dataframe.api.colsOf
9+
import org.jetbrains.kotlinx.dataframe.api.column
10+
import org.jetbrains.kotlinx.dataframe.api.columnGroup
11+
import org.jetbrains.kotlinx.dataframe.api.columnOf
12+
import org.jetbrains.kotlinx.dataframe.api.countDistinct
13+
import org.jetbrains.kotlinx.dataframe.api.dataFrameOf
14+
import org.jetbrains.kotlinx.dataframe.api.distinct
15+
import org.jetbrains.kotlinx.dataframe.api.distinctBy
16+
import org.jetbrains.kotlinx.dataframe.api.drop
17+
import org.jetbrains.kotlinx.dataframe.api.dropLast
18+
import org.jetbrains.kotlinx.dataframe.api.dropNA
19+
import org.jetbrains.kotlinx.dataframe.api.dropNaNs
20+
import org.jetbrains.kotlinx.dataframe.api.dropNulls
21+
import org.jetbrains.kotlinx.dataframe.api.dropWhile
22+
import org.jetbrains.kotlinx.dataframe.api.fillNaNs
23+
import org.jetbrains.kotlinx.dataframe.api.filter
24+
import org.jetbrains.kotlinx.dataframe.api.filterBy
25+
import org.jetbrains.kotlinx.dataframe.api.first
26+
import org.jetbrains.kotlinx.dataframe.api.forEach
27+
import org.jetbrains.kotlinx.dataframe.api.gather
28+
import org.jetbrains.kotlinx.dataframe.api.getColumn
29+
import org.jetbrains.kotlinx.dataframe.api.getColumnGroup
30+
import org.jetbrains.kotlinx.dataframe.api.getColumns
31+
import org.jetbrains.kotlinx.dataframe.api.group
32+
import org.jetbrains.kotlinx.dataframe.api.groupBy
33+
import org.jetbrains.kotlinx.dataframe.api.into
34+
import org.jetbrains.kotlinx.dataframe.api.isColumnGroup
35+
import org.jetbrains.kotlinx.dataframe.api.map
36+
import org.jetbrains.kotlinx.dataframe.api.mapToRows
37+
import org.jetbrains.kotlinx.dataframe.api.maxBy
38+
import org.jetbrains.kotlinx.dataframe.api.maxByOrNull
39+
import org.jetbrains.kotlinx.dataframe.api.minBy
40+
import org.jetbrains.kotlinx.dataframe.api.minus
41+
import org.jetbrains.kotlinx.dataframe.api.move
42+
import org.jetbrains.kotlinx.dataframe.api.named
43+
import org.jetbrains.kotlinx.dataframe.api.notNull
44+
import org.jetbrains.kotlinx.dataframe.api.remove
45+
import org.jetbrains.kotlinx.dataframe.api.rows
46+
import org.jetbrains.kotlinx.dataframe.api.select
47+
import org.jetbrains.kotlinx.dataframe.api.single
48+
import org.jetbrains.kotlinx.dataframe.api.sortBy
49+
import org.jetbrains.kotlinx.dataframe.api.take
50+
import org.jetbrains.kotlinx.dataframe.api.takeLast
51+
import org.jetbrains.kotlinx.dataframe.api.takeWhile
52+
import org.jetbrains.kotlinx.dataframe.api.update
53+
import org.jetbrains.kotlinx.dataframe.api.values
54+
import org.jetbrains.kotlinx.dataframe.api.withZero
55+
import org.jetbrains.kotlinx.dataframe.api.xs
456
import org.jetbrains.kotlinx.dataframe.explainer.TransformDataFrameExpressions
557
import org.jetbrains.kotlinx.dataframe.get
658
import org.junit.Test

core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Analyze.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@file:Suppress("ktlint")
2+
13
package org.jetbrains.kotlinx.dataframe.samples.api
24

35
import org.jetbrains.kotlinx.dataframe.api.aggregate

core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/ApiLevels.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@file:Suppress("ktlint")
2+
13
package org.jetbrains.kotlinx.dataframe.samples.api
24

35
import org.jetbrains.kotlinx.dataframe.DataFrame

core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Collections.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@file:Suppress("ktlint")
2+
13
package org.jetbrains.kotlinx.dataframe.samples.api
24

35
import io.kotest.matchers.shouldBe
@@ -27,6 +29,7 @@ class Collections {
2729
@TransformDataFrameExpressions
2830
fun listInterop2() {
2931
data class Input(val a: Int, val b: Int)
32+
3033
val list = listOf(Input(1, 2), Input(3, 4))
3134
// SampleStart
3235
val df = list.toDataFrame()
@@ -77,6 +80,7 @@ class Collections {
7780
.group("name", "lastName").into("fullName")
7881

7982
data class FullName(val name: String, val lastName: String)
83+
8084
data class Person(val fullName: FullName, val age: Int)
8185

8286
val persons = df.toListOf<Person>() // [Person(fullName = FullName(name = "John", lastName = "Doe"), age = 21)]

core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Create.kt

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@file:Suppress("ktlint")
2+
13
package org.jetbrains.kotlinx.dataframe.samples.api
24

35
import io.kotest.matchers.shouldBe
@@ -241,7 +243,7 @@ class Create : TestBase() {
241243
val df = dataFrameOf("name", "age")(
242244
"Alice", 15,
243245
"Bob", 20,
244-
"Charlie", 100
246+
"Charlie", 100,
245247
)
246248
// SampleEnd
247249
}
@@ -253,7 +255,7 @@ class Create : TestBase() {
253255
// DataFrame with 2 columns and 3 rows
254256
val df = dataFrameOf(
255257
"name" to listOf("Alice", "Bob", "Charlie"),
256-
"age" to listOf(15, 20, 100)
258+
"age" to listOf(15, 20, 100),
257259
)
258260
// SampleEnd
259261
}
@@ -337,7 +339,7 @@ class Create : TestBase() {
337339
val values = listOf(
338340
"Alice", 15,
339341
"Bob", 20,
340-
"Charlie", 22
342+
"Charlie", 22,
341343
)
342344
val df = dataFrameOf(names, values)
343345
// SampleEnd
@@ -379,12 +381,14 @@ class Create : TestBase() {
379381
fun readDataFrameFromDeepObject() {
380382
// SampleStart
381383
data class Name(val firstName: String, val lastName: String)
384+
382385
data class Score(val subject: String, val value: Int)
386+
383387
data class Student(val name: Name, val age: Int, val scores: List<Score>)
384388

385389
val students = listOf(
386390
Student(Name("Alice", "Cooper"), 15, listOf(Score("math", 4), Score("biology", 3))),
387-
Student(Name("Bob", "Marley"), 20, listOf(Score("music", 5)))
391+
Student(Name("Bob", "Marley"), 20, listOf(Score("music", 5))),
388392
)
389393

390394
val df = students.toDataFrame(maxDepth = 1)
@@ -400,12 +404,14 @@ class Create : TestBase() {
400404
@TransformDataFrameExpressions
401405
fun readDataFrameFromDeepObjectWithExclude() {
402406
data class Name(val firstName: String, val lastName: String)
407+
403408
data class Score(val subject: String, val value: Int)
409+
404410
data class Student(val name: Name, val age: Int, val scores: List<Score>)
405411

406412
val students = listOf(
407413
Student(Name("Alice", "Cooper"), 15, listOf(Score("math", 4), Score("biology", 3))),
408-
Student(Name("Bob", "Marley"), 20, listOf(Score("music", 5)))
414+
Student(Name("Bob", "Marley"), 20, listOf(Score("music", 5))),
409415
)
410416

411417
// SampleStart

core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/DataRowApi.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@file:Suppress("ktlint")
2+
13
package org.jetbrains.kotlinx.dataframe.samples.api
24

35
import org.jetbrains.kotlinx.dataframe.api.add

core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Join.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@file:Suppress("ktlint")
2+
13
package org.jetbrains.kotlinx.dataframe.samples.api
24

35
import io.kotest.matchers.shouldBe
@@ -60,6 +62,7 @@ class Join : TestBase() {
6062
}
6163

6264
class Right
65+
6366
val DataFrame<Right>.fullName: ColumnGroup<Name> get() = getColumnGroup("fullName").cast()
6467

6568
@Test

0 commit comments

Comments
 (0)