Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive for const val with non-public marker #245

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Fix false positive for const val with non-public marker #245

merged 4 commits into from
Jun 28, 2024

Conversation

martinbonnin
Copy link
Contributor

Attempt at fixing #90.

@martinbonnin martinbonnin mentioned this pull request Jun 27, 2024
Closed
fzhinkin
fzhinkin requested changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@fzhinkin fzhinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinbonnin, thanks for addressing the issue! Overall, the change looks good, I have just a few minor nits.

src/functionalTest/kotlin/kotlinx/validation/test/NonPublicMarkersTest.kt Show resolved Hide resolved
src/main/kotlin/api/KotlinSignaturesLoading.kt Outdated Show resolved Hide resolved
@martinbonnin martinbonnin force-pushed the const-false-positive branch from 7764ffb to ff78c5b Compare June 28, 2024 08:58
@fzhinkin fzhinkin self-requested a review June 28, 2024 09:30
fzhinkin
fzhinkin approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@fzhinkin fzhinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll merge it later today

@fzhinkin fzhinkin changed the base branch from master to develop June 28, 2024 10:19
@fzhinkin fzhinkin merged commit 0dd6e41 into Kotlin:develop Jun 28, 2024
3 checks passed
This was referenced Jul 8, 2024
Closed
Merged
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Oct 28, 2024
@martinbonnin @shanshin
[ABI Validation] Fix false positive for const val with non-public marker
724c5d5 
Closes Kotlin/binary-compatibility-validator#90 
Pull request Kotlin/binary-compatibility-validator#245
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 3, 2024
@martinbonnin @shanshin
[ABI Validation] Fix false positive for const val with non-public marker
c854272 
Closes Kotlin/binary-compatibility-validator#90 
Pull request Kotlin/binary-compatibility-validator#245
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 13, 2024
@martinbonnin @shanshin
[ABI Validation] Fix false positive for const val with non-public marker
dd785c0 
Closes Kotlin/binary-compatibility-validator#90 
Pull request Kotlin/binary-compatibility-validator#245
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 23, 2024
@martinbonnin @shanshin
[ABI Validation] Fix false positive for const val with non-public marker
70f56a0 
Closes Kotlin/binary-compatibility-validator#90 
Pull request Kotlin/binary-compatibility-validator#245

Moved from Kotlin/binary-compatibility-validator@0dd6e41
KotlinBuild pushed a commit to JetBrains/kotlin that referenced this pull request Jan 3, 2025
@martinbonnin @qodana-bot
[ABI Validation] Fix false positive for const val with non-public marker
71ac494 
Closes Kotlin/binary-compatibility-validator#90 
Pull request Kotlin/binary-compatibility-validator#245

Moved from Kotlin/binary-compatibility-validator@0dd6e41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhinkin fzhinkin fzhinkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @fzhinkin