-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group dumped declaration by declaration kind (class, function, property, etc.) #224
Conversation
a9a5b5a
to
41770eb
Compare
I have a feeling that the sorting test doesn't specifically test sorting inside groups. For example, try replacing |
@ilya-g using a fixed value instead of But I agree that a test explicitly covering ordering is missing, I'll add it. |
… function, property, etc.) Closes Kotlin/binary-compatibility-validator#197 Pull request Kotlin/binary-compatibility-validator#224
… function, property, etc.) Closes Kotlin/binary-compatibility-validator#197 Pull request Kotlin/binary-compatibility-validator#224
… function, property, etc.) Closes Kotlin/binary-compatibility-validator#197 Pull request Kotlin/binary-compatibility-validator#224
… function, property, etc.) Closes Kotlin/binary-compatibility-validator#197 Pull request Kotlin/binary-compatibility-validator#224 Moved from Kotlin/binary-compatibility-validator@a835a73
… function, property, etc.) Closes Kotlin/binary-compatibility-validator#197 Pull request Kotlin/binary-compatibility-validator#224 Moved from Kotlin/binary-compatibility-validator@a835a73
Currently, all dumped declarations are sorted lexicographically, potentially by mixing different kinds of declarations. That approach differs from what we do for JVM dumps, where declarations are grouped by a declaration kind.
With this change, declarations will be ordered as follows:
This PR introduces the following order:
Closes #197