Add all interface's class-level annotations to its DefaultImpls class. #161
Conversation
fzhinkin
force-pushed
the
155-take-defaultimpls-annotations-from-original-interface
branch
from
27424fd to
493ba62
Compare
| /** | ||
| * For synthetic $DefaultImpls classes copy annotations from the original interface | ||
| */ | ||
| val inheritedAnnotations = mutableListOf<AnnotationNode>().apply { |
There was a problem hiding this comment.
Could you please check if it is possible to consolidate annotation "inheritance" in a single place?
AFAIR we have a multitude of such logic, some examples are:
PublishedApiand methods with default arguments- Regular annotations (e.g.
@PrivateApi) and methods with default arguments - Nested objects/companions and
@JvmStatic - Companions and
INSTANCE - Fields and accessors
There was a problem hiding this comment.
It seems like now there are only 3 cases when we're "inheriting" ("propagating" would fit better, I guess) annotations for an entity from some other entities:
- for fields, we're taking annotations from accessors (and with Add all Companion class' annotations to corresponding Companion field. #162 we'll propagate companion class' annotations to the corresponding field);
- for methods, we're taking annotations from other property accessors and fields and also from a regular method declaration if the current one is "$default";
- for classes, if a class is "$DefaultImpls", we're taking annotations from the "original" class.
Currently, the logic is local w.r.t. the entity's processing scope (i.e. we're collecting annotations for a field when processing a field, for a method when processing that method and so on) and I'm not sure if we could do significantly better.
There's always an option to rewrite all the processing logic to have a single object encompassing the whole context (instead of tossing parts of that context across various extension functions) and have (still) separate methods responsible for annotation extraction there, but I think it is out of this PR's scope.
There was a problem hiding this comment.
Thanks for taking a look!
…efaultImpls class. Fixes Kotlin/binary-compatibility-validator#155 Pull request Kotlin/binary-compatibility-validator#161
…efaultImpls class. Fixes Kotlin/binary-compatibility-validator#155 Pull request Kotlin/binary-compatibility-validator#161
…efaultImpls class. Fixes Kotlin/binary-compatibility-validator#155 Pull request Kotlin/binary-compatibility-validator#161
…efaultImpls class. Fixes Kotlin/binary-compatibility-validator#155 Pull request Kotlin/binary-compatibility-validator#161 Moved from Kotlin/binary-compatibility-validator@1d7505b
…efaultImpls class. Fixes Kotlin/binary-compatibility-validator#155 Pull request Kotlin/binary-compatibility-validator#161 Moved from Kotlin/binary-compatibility-validator@1d7505b
Fixes #155