Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when using version 0.16.2 in projects with a Gradle version older than 8.2 #263

Closed
qurbonzoda opened this issue Jul 25, 2024 · 3 comments · Fixed by #265
Closed

Error when using version 0.16.2 in projects with a Gradle version older than 8.2 #263

qurbonzoda opened this issue Jul 25, 2024 · 3 comments · Fixed by #265

Comments

@qurbonzoda
Copy link

qurbonzoda commented Jul 25, 2024 •
edited
Loading

The error is:

* What went wrong:
'void org.gradle.api.artifacts.Configuration.setCanBeDeclared(boolean)'

I suppose the problem was introduced in the last release, specifically because of using configuration.isCanBeDeclared in this file:

binary-compatibility-validator/src/main/kotlin/BinaryCompatibilityValidatorPlugin.kt

Line 662 in 14ebd02

it.isCanBeDeclared = true

setCanBeDeclared was introduced in Gradle 8.2
@qwwdfsad
Copy link
Contributor

@ALikhachev could you please take a look?

@ALikhachev
Copy link
Member

ALikhachev commented Jul 25, 2024 •
edited
Loading

Indeed. Perhaps we could add a simple version guard on the problematic call. Missed this during review of #256 😞 In the perfect scenario tests should catch such problems

@Goooler Goooler mentioned this issue Jul 27, 2024
Closed
@Goooler
Copy link
Contributor

Goooler commented Jul 27, 2024

Addressing the fix to #264.

@Goooler Goooler mentioned this issue Jul 27, 2024
Merged
shanshin added a commit that referenced this issue Jul 31, 2024
@shanshin
Fixed support for Gradle < 8.2
7d0caff 
Fixes #263
@shanshin shanshin mentioned this issue Jul 31, 2024
Closed
shanshin added a commit that referenced this issue Jul 31, 2024
@shanshin
Fixed support for Gradle < 8.2
7d9038b 
Fixes #263
shanshin pushed a commit that referenced this issue Jul 31, 2024
@Goooler
Fixed support for Gradle < 8.2 (#265)
c00ca4b 
Fixes #263
qurbonzoda added a commit to Kotlin/kotlinx.collections.immutable that referenced this issue Aug 23, 2024
@qurbonzoda
Bump binary-compatibility-validator version to 0.16.3
edb2ed9 
Fixes Kotlin/binary-compatibility-validator#263
qurbonzoda added a commit to Kotlin/kotlinx.collections.immutable that referenced this issue Sep 4, 2024
@qurbonzoda
Bump binary-compatibility-validator version to 0.16.3
c4f456b 
Fixes Kotlin/binary-compatibility-validator#263
shanshin pushed a commit to JetBrains/kotlin that referenced this issue Oct 28, 2024
@Goooler @shanshin
[ABI Validation] Fixed support for Gradle < 8.2
58a8534 
Fixes Kotlin/binary-compatibility-validator#263
Pull request Kotlin/binary-compatibility-validator#265
shanshin pushed a commit to JetBrains/kotlin that referenced this issue Dec 3, 2024
@Goooler @shanshin
[ABI Validation] Fixed support for Gradle < 8.2
54dc21b 
Fixes Kotlin/binary-compatibility-validator#263
Pull request Kotlin/binary-compatibility-validator#265
shanshin pushed a commit to JetBrains/kotlin that referenced this issue Dec 13, 2024
@Goooler @shanshin
[ABI Validation] Fixed support for Gradle < 8.2
af5c051 
Fixes Kotlin/binary-compatibility-validator#263
Pull request Kotlin/binary-compatibility-validator#265
shanshin pushed a commit to JetBrains/kotlin that referenced this issue Dec 23, 2024
@Goooler @shanshin
[ABI Validation] Fixed support for Gradle < 8.2
1fa75c2 
Fixes Kotlin/binary-compatibility-validator#263
Pull request Kotlin/binary-compatibility-validator#265

Moved from Kotlin/binary-compatibility-validator@c00ca4b
KotlinBuild pushed a commit to JetBrains/kotlin that referenced this issue Jan 3, 2025
@Goooler @qodana-bot
[ABI Validation] Fixed support for Gradle < 8.2
d41ffe8 
Fixes Kotlin/binary-compatibility-validator#263
Pull request Kotlin/binary-compatibility-validator#265

Moved from Kotlin/binary-compatibility-validator@c00ca4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ALikhachev @qwwdfsad @Goooler @qurbonzoda