Skip to content

ReadSTM: fix STM signature checks to be case-sensitive. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2022
Merged

ReadSTM: fix STM signature checks to be case-sensitive. #39

merged 1 commit into from
Jan 28, 2022

Conversation

sezero
Copy link
Contributor

@sezero sezero commented Jul 25, 2018

No description provided.

@sagamusix
Copy link
Contributor

Technically it doesn't matter what's put in those fields, ST2 and ST3 don't care about them. Another value that has been found in the wild for this field is "SWavePro", and "WUZAMOD!" supposedly exists, too (probably from a MOD->STM converter).
This should probably just check for valid ASCII characters (32-127) and validate all other header fields very toughly, like OpenMPT does.

@sezero
Copy link
Contributor Author

sezero commented Aug 2, 2018

Technically maybe, who knows, but are there any file in the wild
with case-insensitive versions of those sigs, e.g. "!SCREAM!" and
not "!Scream!"? Both libxmp and and libmikmod checks those sigs
case-sensitively; only libmodplug does it case-insensitively..

"SWavePro", and "WUZAMOD!"

Yeah, but I only touched what libmodplug checks at present.

@sagamusix
Copy link
Contributor

I don't know if such files exist, but I thought that while you already fix this, you might just as well fix it with all cases in mind.

@sezero
Copy link
Contributor Author

sezero commented Aug 2, 2018

I don't know of any either. So, I'd rather stick to existing sigs and
check them case-sensitively to avoid any false positives.

berenm pushed a commit to bminor/SDL_mixer that referenced this pull request Oct 24, 2018
@sezero
update / reconfigure libmodplug and rebuild it:
26c71c3 
- disable wav formats handling: SDL_mixer has its own code for it.
- disable midi formats handling: SDL_mixer has timidity or native midi for it.
- disable experimental (possibly broken) file save support: not used, ever.
- don't export cplusplus interface from shared libs. SDL_mixer doesn't use it.
- disable mmcmp unpacking. disable broken pp20 unpacking.
- merge Konstanty/libmodplug#36 (fix PSM loader overwrites const data)
- merge Konstanty/libmodplug#39 (case-sensitive STM signature checks)
- merge Konstanty/libmodplug#40 (big-endian-friendly MDL track length read)
- merge Konstanty/libmodplug#24 (make some stuff static)
- merge Konstanty/libmodplug#14 (NO_PACKING and MODPLUG_NO_FILESAVE ifdefs)
- merge Konstanty/libmodplug#32 (replace setenv)
- merge Konstanty/libmodplug#41 (timidity paths update)
SDL-mirror-bot pushed a commit to SDL-mirror/SDL_mixer that referenced this pull request Oct 24, 2018
@sezero
update / reconfigure libmodplug and rebuild it:
c02f808 
- disable wav formats handling: SDL_mixer has its own code for it.
- disable midi formats handling: SDL_mixer has timidity or native midi for it.
- disable experimental (possibly broken) file save support: not used, ever.
- don't export cplusplus interface from shared libs. SDL_mixer doesn't use it.
- disable mmcmp unpacking. disable broken pp20 unpacking.
- merge Konstanty/libmodplug#36 (fix PSM loader overwrites const data)
- merge Konstanty/libmodplug#39 (case-sensitive STM signature checks)
- merge Konstanty/libmodplug#40 (big-endian-friendly MDL track length read)
- merge Konstanty/libmodplug#24 (make some stuff static)
- merge Konstanty/libmodplug#14 (NO_PACKING and MODPLUG_NO_FILESAVE ifdefs)
- merge Konstanty/libmodplug#32 (replace setenv)
- merge Konstanty/libmodplug#41 (timidity paths update)
Akaricchi pushed a commit to taisei-project/SDL2_mixer that referenced this pull request Jun 2, 2020
@sezero
update / reconfigure libmodplug and rebuild it:
84c4037 
- disable wav formats handling: SDL_mixer has its own code for it.
- disable midi formats handling: SDL_mixer has timidity or native midi for it.
- disable experimental (possibly broken) file save support: not used, ever.
- don't export cplusplus interface from shared libs. SDL_mixer doesn't use it.
- disable mmcmp unpacking. disable broken pp20 unpacking.
- merge Konstanty/libmodplug#36 (fix PSM loader overwrites const data)
- merge Konstanty/libmodplug#39 (case-sensitive STM signature checks)
- merge Konstanty/libmodplug#40 (big-endian-friendly MDL track length read)
- merge Konstanty/libmodplug#24 (make some stuff static)
- merge Konstanty/libmodplug#14 (NO_PACKING and MODPLUG_NO_FILESAVE ifdefs)
- merge Konstanty/libmodplug#32 (replace setenv)
- merge Konstanty/libmodplug#41 (timidity paths update)
@sezero
Copy link
Contributor Author

sezero commented Sep 27, 2020

PING ?

1 similar comment
@sezero
Copy link
Contributor Author

sezero commented Nov 29, 2020

PING ?

icculus pushed a commit to icculus/SDL_sound that referenced this pull request Jun 28, 2021
@sezero
libmodplug (ReadSTM): fixed STM signature checks to be case-sensitive.
17e44ae 
(see: Konstanty/libmodplug#39)
icculus pushed a commit to icculus/SDL_sound that referenced this pull request Jun 28, 2021
@sezero
libmodplug (ReadSTM): fixed STM signature checks to be case-sensitive.
be84a11 
(see: Konstanty/libmodplug#39)
icculus pushed a commit to icculus/SDL_sound that referenced this pull request Jun 28, 2021
@sezero
libmodplug (ReadSTM): fixed STM signature checks to be case-sensitive.
41fbb2d 
(see: Konstanty/libmodplug#39)
icculus pushed a commit to icculus/SDL_sound that referenced this pull request Jun 28, 2021
@sezero
libmodplug (ReadSTM): fixed STM signature checks to be case-sensitive.
bc389e8 
(see: Konstanty/libmodplug#39)
@Konstanty Konstanty merged commit 1fdbffd into Konstanty:master Jan 28, 2022
Wolf3s pushed a commit to Wolf3s/PS2SDL_mixer-1.2.12 that referenced this pull request Mar 30, 2024
@sezero
update / reconfigure libmodplug and rebuild it:
87f086e 
- disable wav formats handling: SDL_mixer has its own code for it.
- disable midi formats handling: SDL_mixer has timidity or native midi for it.
- disable experimental (possibly broken) file save support: not used, ever.
- don't export cplusplus interface from shared libs. SDL_mixer doesn't use it.
- disable mmcmp unpacking. disable broken pp20 unpacking.
- merge Konstanty/libmodplug#36 (fix PSM loader overwrites const data)
- merge Konstanty/libmodplug#39 (case-sensitive STM signature checks)
- merge Konstanty/libmodplug#40 (big-endian-friendly MDL track length read)
- merge Konstanty/libmodplug#24 (make some stuff static)
- merge Konstanty/libmodplug#14 (NO_PACKING and MODPLUG_NO_FILESAVE ifdefs)
- merge Konstanty/libmodplug#32 (replace setenv)
- merge Konstanty/libmodplug#41 (timidity paths update)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sezero @sagamusix @Konstanty