Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension - Re-check min amount on popup Pay attention in case there is not enough balance to stake #3930

Closed
haiyenvu23 opened this issue Dec 17, 2024 · 3 comments · May be fixed by #3800
Closed
Assignees
Milestone

Comments

@haiyenvu23
Copy link

haiyenvu23 commented Dec 17, 2024

Describe the task
Re-check min amount on popup Pay attention in case there is not enough balance to stake

Actual : Shows min amount as 0.5 even though balance has 1 DOT

Image

Image

Expect : Show the correct min amount to avoid confusing users

@haiyenvu23
Copy link
Author

haiyenvu23 commented Dec 30, 2024

Version test : http://localhost:8900/s/bAoz5RjGFbsN33a
Account test : 1jmxua3SLJQTjoJJz9XoCutjdgK3McJJ6jSKqSAerxqyzBf

  • Re-check max transferable when perform XCM on Transfer features
  • Re-check logic validate when perform stake
  • Re-check show min balance calculation on popup
    Expect : Min stake - Transferable + 0.01
    Image

@haiyenvu23
Copy link
Author

haiyenvu23 commented Dec 31, 2024

Version test : http://localhost:8900/s/NgHH7Bio8HABESg

  • Update content for popup
    Expect : "You need to deposit an additional {x} DOT (Bifrost Polkadot) or {y} DOT (Polkadot) to start earning "

@haiyenvu23
Copy link
Author

Version test : http://localhost:8900/s/mBte4AGwLPkzcQJ
Validation passed in case :

  • Install/update version

  • Check with specific account/all account mode

  • Re-check max transferable when perform XCM on Transfer features :

    • Has locked
      Account test : 16ZL8yLyXv3V3L3z9ofR1ovFLziyXaN1DPq4yffMAZ9czzBD
      Image

    • Not locked :
      Account test : 1BzDB5n2rfSJwvuCW9deKY9XnUyys8Gy44SoX8tRNDCFBhx
      Image

  • Re-check show min balance calculation on popup
    Account test : 15u5Mc3nEiX671EardtpjPSwVNpnp2AL6Zy6zL17AUeTVnJA
    Image

  • Re-check logic validate when perform stake

  • Re-check when stake other network

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants