Skip to content

Conversation

@pmalek
Copy link
Member

@pmalek pmalek commented Jun 12, 2023

This PR makes the e2e tests to run in separate jobs, this making the CI faster by parallelizing the tests.

Similar approach has already been done for integration tests:

setup-integration-tests:
runs-on: ubuntu-latest
outputs:
test_names: ${{ steps.set_test_names.outputs.test_names }}
steps:
- uses: actions/checkout@v3
- id: set_test_names
name: Set test names
working-directory: test/integration/
# grep magic described in https://unix.stackexchange.com/a/13472
# sed to add the extra $ is because some of our test names overlap. we need it so the -run regex only matches one test
run: |
echo "test_names=$(grep -shoP "(?<=^func )(Test[a-zA-z_0-9]+)(?=\(t \*testing.T\) {)" * | sed -e "s/$/\$/"| jq -R . | jq -cs .)" >> $GITHUB_OUTPUT
- name: Print test names
run: echo "Test names ${{ steps.set_test_names.outputs.test_names }}"

@pmalek pmalek requested a review from a team as a code owner June 12, 2023 10:54
@pmalek pmalek self-assigned this Jun 12, 2023
@pmalek pmalek requested a review from shaneutt as a code owner June 12, 2023 10:54
@pmalek pmalek temporarily deployed to gcloud June 12, 2023 10:54 — with GitHub Actions Inactive
@pmalek pmalek force-pushed the ci-separate-e2e-test-jobs branch from cb3a483 to de13981 Compare June 12, 2023 10:55
@pmalek pmalek temporarily deployed to gcloud June 12, 2023 10:56 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud June 12, 2023 10:56 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (609bf67) 59.70% compared to head (22cd778) 59.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   59.70%   59.70%           
=======================================
  Files          43       43           
  Lines        3474     3474           
=======================================
  Hits         2074     2074           
  Misses       1131     1131           
  Partials      269      269           
Flag Coverage Δ
integration-test 59.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmalek pmalek temporarily deployed to gcloud June 12, 2023 11:08 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud June 12, 2023 11:08 — with GitHub Actions Inactive
@pmalek pmalek enabled auto-merge (squash) June 12, 2023 11:18
@programmer04 programmer04 disabled auto-merge June 12, 2023 11:32
programmer04
programmer04 previously approved these changes Jun 12, 2023
@pmalek pmalek temporarily deployed to gcloud June 12, 2023 11:51 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud June 12, 2023 11:51 — with GitHub Actions Inactive
@pmalek pmalek force-pushed the ci-separate-e2e-test-jobs branch from 22cd778 to c866cad Compare June 12, 2023 12:06
@pmalek pmalek enabled auto-merge (squash) June 12, 2023 12:07
@pmalek pmalek temporarily deployed to gcloud June 12, 2023 12:10 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud June 12, 2023 12:10 — with GitHub Actions Inactive
@pmalek pmalek merged commit 13a3d4c into main Jun 12, 2023
@pmalek pmalek deleted the ci-separate-e2e-test-jobs branch June 12, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants