Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that cleanup is complete #347

Open
1 of 2 tasks
mlavacca opened this issue Aug 19, 2022 · 0 comments
Open
1 of 2 tasks

Verify that cleanup is complete #347

mlavacca opened this issue Aug 19, 2022 · 0 comments
Labels
area/feature New feature or request

Comments

@mlavacca
Copy link
Member

mlavacca commented Aug 19, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

In KGO the Dataplane has a couple of finalizers that are needed to perform the deletion of cluster-wide resources (ClusterRoles and ClusterRoleBindings). When the Dataplane is deleted, the controller is in charge of collecting the cluster-wide resources and removing the finalizer from the Dataplane, so that it can be collected as well.
All the integration tests use the cleaner utility to perform the cleanup. In that function, all the resources marked to be collected are deleted, but there is no check that those resources have been really deleted.
When having resources with finalizers, it is not enough, because it happens that those resources are marked for deletion, but there is no controller in place to remove the finalizers, hence they hang forever marked for deletion.

Proposed Solution

cleaner.Cleanup should be improved so that after deleting each resource, it should periodically check that all the resources don't actually exist anymore. Only when all the resources are really deleted, the cleanup can return and the test can be concluded.

Additional information

No response

Acceptance Criteria

  • In the KGO integration tests all the resources are correctly collected.
@mlavacca mlavacca added the area/feature New feature or request label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants