Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Konnect clients in client provider #6340

Open
2 of 4 tasks
Tracked by #6325
randmonkey opened this issue Jul 23, 2024 · 0 comments
Open
2 of 4 tasks
Tracked by #6325

Remove Konnect clients in client provider #6340

randmonkey opened this issue Jul 23, 2024 · 0 comments
Labels
area/konnect Issues and PRs related to Konnect area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality.
Milestone

Comments

@randmonkey
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

Split from #6325.
When we move uploading config to Konnect to a separate loop, we do not need to keep them in client provider and remove the related processing code in KongClient for sending config to Konnect. Removing them in code would reduce the complexity and make code cleaner.

Proposed Solution

  • After we successfully moved config uploading to Konnect to a separate loop, remove KonnectClient in client provider
  • Remove the code in KongClient to do special processes on sending config to Konnect

Additional information

Not a strong requirement for releasing the separate loop feature, but would make code and tests cleaner. So I did not add the release/required label.

Acceptance Criteria

  • KonnectClient is removed in clients provider
  • Process specific to sending configuration to Konnect is removed in KongClinent
@randmonkey randmonkey added area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/konnect Issues and PRs related to Konnect labels Jul 23, 2024
@randmonkey randmonkey added this to the KIC v3.3.x milestone Jul 23, 2024
@randmonkey randmonkey modified the milestones: KIC v3.3.x, KIC v3.4.x Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/konnect Issues and PRs related to Konnect area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality.
Projects
None yet
Development

No branches or pull requests

1 participant