Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of tcpMutex, tlsMutex and ingressClassMutex from integration tests #5757

Open
1 of 3 tasks
programmer04 opened this issue Mar 27, 2024 · 5 comments
Open
1 of 3 tasks
Assignees

Comments

@programmer04
Copy link
Member

programmer04 commented Mar 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

Some integration tests require

var (
tcpMutex sync.Mutex
tlsMutex sync.Mutex
)

those tests should be migrated to isolated tests. UDP-related tests have been already migrated as a byproduct of fighting with flakes.

Similar situation is for ingressClassMutex.

Also, it's a great opportunity for improvement and cleanups, e.g. usage of assertion helpers from test/integration/isolated/assertion_helpers.go. See UDP corresponding tests for inspiration.

Proposed Solution

  • tests are migrated to isolated
  • tcpMutex, tlsMutex and ingressClassMutex are no longer needed

Acceptance Criteria

  • tests are migrated to isolated
  • tcpMutex, tlsMutex and ingressClassMutex are removed
@YiTongG
Copy link

YiTongG commented Jun 28, 2024

Hi ~ I want to help, can you assign this tasks to me?

@programmer04
Copy link
Member Author

Sure @YiTongG, you can try

@LindaSummer
Copy link
Contributor

Hi @programmer04 ,

This issue seems to be inactive for one more month.
I'm a newbie of Kong community and want to make some contribution.

Can this issue be assigned to me?

Best Regards,
Edward

@YiTongG YiTongG removed their assignment Aug 12, 2024
@programmer04
Copy link
Member Author

Please try @LindaSummer, I've assigned it to you. In case of any questions do not hesitate to reach me

@LindaSummer
Copy link
Contributor

I've assigned it to you. In case of any questions do not hesitate to reach me

Hi @programmer04 ,

Thanks very much! 😊
I will try to be familiar with the codebase structure and the testing flow these days.

Best Regards,
Edward

@programmer04 programmer04 changed the title Get rid of tcpMutex and tlsMutex from integration tests Get rid of tcpMutex, tlsMutex and ingressClassMutex from integration tests Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants