Bump actions upload-artifact and download-artifact from 3 to 4

[programmer04]

Is there an existing issue for this?

• I have searched the existing issues

Problem Statement

Updating

• actions/upload-artifact - doesn't allow upload multiple times with the same name - breaking change
• actions/download-artifact - breaking changes

have to be done together and require adjustments in workflows, because currently, we reuse names in workflows

Supersedes

• chore(deps): bump actions/download-artifact from 3 to 4 #5350
• chore(deps): bump actions/upload-artifact from 3 to 4 #5348

Proposed Solution

No response

Additional information

No response

Acceptance Criteria

• actions are bumped from 3 to 4 and everything works as used to work

[rainest]

I attempted an upgrade that changed names around, but ran into an issue handling the consolidation step.

Our current download jobs rely on all artifacts having the same name, which isn't possible on v4. Downloading currently only supports a single name or downloading all artifacts, without any obvious designated pattern for separating out different groups (codecov versus buildpulse, in our case).

actions/download-artifact#248 (comment) proposes adding a name-prefix option that looks like what we'd need, but is pending review.

[programmer04]

Version 4.1.0 contains this feature

• Support pattern matching to filter artifacts & merge to same directory actions/download-artifact#259