Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: set NotAllowedByListeners in HTTPRoute status #3726

Closed
1 of 2 tasks
mlavacca opened this issue Mar 14, 2023 · 1 comment · Fixed by #4142
Closed
1 of 2 tasks

conformance: set NotAllowedByListeners in HTTPRoute status #3726

mlavacca opened this issue Mar 14, 2023 · 1 comment · Fixed by #4142
Assignees
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API priority/low
Milestone

Comments

@mlavacca
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

When the HTTPRoute references a listener in a different namespace, and there is an invalid ReferenceGrant that allows it, we need to set the NotAllowedByListeners reason in the Accepted condition.

More details: kubernetes-sigs/gateway-api#1714

Proposed Solution

No response

Additional information

No response

Acceptance Criteria

  • the conformance test HTTPRouteInvalidCrossNamespaceParentRef is passing after having bumped the Gateway API to 0.6.2 (still unreleased at the moment of writing)
@mlavacca mlavacca added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Mar 14, 2023
@mlavacca mlavacca added this to the KIC v2.10.0 milestone Mar 14, 2023
@mheap mheap modified the milestones: KIC v2.10.0, KIC v2.11.0 May 5, 2023
@mflendrich mflendrich modified the milestones: KIC v2.11.0, KIC v2.10.0 May 12, 2023
@mflendrich mflendrich modified the milestones: KIC v2.10.0, KIC v2.11.0 May 19, 2023
@rainest rainest self-assigned this Jun 6, 2023
@rainest
Copy link
Contributor

rainest commented Jun 6, 2023

This was apparently already passing after some point? I did nothing other than update to 0.7.1 and it passed (other tests failed): b3964c2

2023-06-06T21:34:00.6679796Z     --- PASS: TestGatewayConformance/HTTPRouteInvalidCrossNamespaceParentRef (1.05s)
2023-06-06T21:34:00.6680909Z         --- PASS: TestGatewayConformance/HTTPRouteInvalidCrossNamespaceParentRef/HTTPRoute_should_have_an_Accepted:_false_condition_with_reason_NotAllowedByListeners (0.01s)
2023-06-06T21:34:00.6681932Z         --- PASS: TestGatewayConformance/HTTPRouteInvalidCrossNamespaceParentRef/Route_should_not_have_Parents_set_in_status (0.00s)
2023-06-06T21:34:00.6683026Z         --- PASS: TestGatewayConformance/HTTPRouteInvalidCrossNamespaceParentRef/Gateway_should_have_0_Routes_attached (1.01s)

That was without the code to explicitly check it (1507095). Not sure when or what would have changed it earlier since it looks like most of the code to set the not allowed status was added before this was filed originally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API priority/low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants