Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests not idempotent because of faulty cleanup #2652

Open
1 task done
mlavacca opened this issue Jul 6, 2022 · 1 comment
Open
1 task done

Integration tests not idempotent because of faulty cleanup #2652

mlavacca opened this issue Jul 6, 2022 · 1 comment

Comments

@mlavacca
Copy link
Member

mlavacca commented Jul 6, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When integration tests are executed, a lot of cleaning functions are deferred to the end of the test. The problem is that we use the exitOnErr function to assert that no error must occur. Whenever such a function fails, the program exits, and all the deferred functions are not executed anymore. This leads to having orphaned resources.

Expected Behavior

We should use the new mechanism introduced in KTF to clean resources, instead of the deferred functions. See #2618 as a similar issue in KTF.

@mlavacca mlavacca added bug Something isn't working area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Jul 6, 2022
@mflendrich mflendrich added area/debt area/tests priority/low onboarding and removed area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Jul 26, 2022
@mflendrich mflendrich changed the title Integration tests cleanup not correctly performed Integration tests not idempotent because of faulty cleanup Aug 2, 2022
@mflendrich
Copy link
Contributor

Currently we don't see strong drivers behind this issue. Does not conern CI runs; @jrsmroz worked around this by purging the kind cluster between re-runs. Labeling as nice-to-have therefore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants