-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add route not allowed status for GWAPI routes #2417
Comments
Blocked on kubernetes-sigs/gateway-api#1111, which appears to be requesting something similar that can serve the same purpose. Over a week ago someone mentioned they were taking it on, I'm inquiring whether they're still doing that and if so we'll continue holding this as blocked and if not I'll make the PR myself. |
Alright looks like I'll be taking on kubernetes-sigs/gateway-api#1111, unblocked. |
After doing some more catching up on recent events in Gateway, it looks like https://github.com/kubernetes-sigs/gateway-api/pull/1114/files actually provided what we need to resolve this as we were just looking for a status update for invalid routes. So now the implementation is to simply mark accepted as false and provide a clear reason when a route is rejected and we should be all set. this does not however need to hold up the milestone so I'm removing that. |
This appears to be done as of 525b2f4 After that we began appending Gateways with not allowed reasons to route status. Closing pending something I'm missing, but I can't think of anything: kubernetes-ingress-controller/internal/controllers/gateway/route_utils.go Lines 224 to 257 in 525b2f4
|
When a GWAPI Route controller cannot ingest a Route because it does not match any of the listeners' AllowedRoutes criteria, we should set a status indicating this.
This status does not yet exist upstream. Adding it is blocked on related pending upstream changes. See #2389 (comment) for details.
The text was updated successfully, but these errors were encountered: