Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit all autogenerated CRDs and explain all diffs against hand-written ones #1761

Closed
1 of 3 tasks
mflendrich opened this issue Aug 26, 2021 · 3 comments
Closed
1 of 3 tasks

Comments

@mflendrich
Copy link
Contributor

mflendrich commented Aug 26, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

Ensure that no unwanted difference occurs in autogenerated CRDs, as opposed to the hand-written CRDs.

Proposed Solution

  • For each bit of difference between the handwritten CRDs from KIC 1.x (converting them to v1 CRDs first!), and the autogenerated ones coming out of Kubebuilder, perform a diff operation and either justify each line of diff, or make an issue to have it resolved (unless one already exists). In particular, audit for non-schema metadata changes such as additionalPrinterColumns.
  • When we start work on this again, we need to re-enable the Kustomization override in 8ae7e29, also described in Manually manage Kong<TYPE> CRDs #1763 (review) until Add dedicated types for KongIngress #1778 is done.

Additional information

No response

Acceptance Criteria

No response

@mflendrich
Copy link
Contributor Author

I think that this is a blocker for use of autogenerated CRDs in GA KIC.

@rainest
Copy link
Contributor

rainest commented Aug 31, 2021

When we start work on this again, we need to re-enable the Kustomization override in 8ae7e29, also described in #1763 (review) until #1778 is done.

@mflendrich
Copy link
Contributor Author

Closed "won't fix". Obsoleted by https://github.com/Kong/kubernetes-ingress-controller/milestone/20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants